Commit Graph
4 Commits
Author SHA1 Message Date
Sameh KhamisandManjunath Paparaju 3404730d41 Let streets named for keys and codes through, and share a request in flight
From review of the first pass:
- Places again: "Secret Key Lake", "Access Token Road", "GATE CODE LANE",
  "OTP Bank", "Auth Code ABCD Street", "California 90210-1234",
  "Cambridge MA. 02139-4307", "12, 10115 Berlin". A key after a space must
  be long, a bare code must hold a digit or be capitals after a label
  that is not and end the line, and ZIP+4 follows a state's code or name.
- Private now: "gate code: abcd", "PIN A7B2", "OTP-ABCDEF", "login code
  ab-12-cd", "auth_token=abc".
- The same text asked while its request is out waits for that answer,
  however slow it is.
- A street without a house number is not named by the street alone.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 14:45:05 -08:00
Sameh KhamisandManjunath Paparaju b7a9fa1c21 Keep more private text from place suggestions, and name houses by their street
- Not sent any more: "john @Gmail.com" (a capital after "@"), "030 12345"
  and "Alice 12345-6789" (read as a house number and postcode),
  "access_token=abcdef", a key in quotes or brackets, and letter codes
  after a code label ("OTP: ABCDEF", "verification code ABCDEF").
- Sent now: "10 Downing Street SW1A2AA, London" (the comma hid the
  postcode). "Pin Oak" and "Gate Code Lane" stay places.
- A house Photon returns without a name is named by its number and street,
  so 10 and 12 Downing Street are two suggestions, not one "London".
- The same text asked twice at once is sent once.
- The village pack's build finds twins near the poles and across 180°;
  the shipped tiles are unchanged.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 14:45:05 -08:00
Sameh KhamisandManjunath Paparaju c06aa37ce2 Keep the place suggester's fair-use and privacy promises
- One spacing, pause and cache for the whole tab, so a search box put up
  again does not start afresh.
- A failed request or a timeout pauses suggestions for a minute, as a
  refusal does.
- A number named as a card, a phone or an account keeps its digits
  together, so no address is read out of them; a UK postcode written
  without its space is a place, not a password.
- The docs say exactly what is sent.

Co-authored-by: Manjunath Paparaju <[email protected]>
2026-11-18 12:20:42 -08:00
Manjunath PaparajuandSameh Khamis bd7b389cef Suggest places from Photon while a place is typed
The suggester asks Photon, the place search's keyless geocoder, for
candidates as a place is typed: at most one request every 500 ms, a six
second limit, and none for a minute after a refusal. Text that may be
private (an email address, seven or more digits however separated, an
IBAN shape, a password, PIN, token or key) is never sent. It also lists a
region's bundled cities and tells whether a place lies in an extent, for
the search box's place strip. The browser's Photon setting is read in one
place.

Co-authored-by: Sameh Khamis <[email protected]>
2026-11-18 12:20:42 -08:00