mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-20 02:02:21 +00:00
fix(annotations): sample arrow, route and area points outside the view (#1277)
A point of an arrow, route or area outside the view frustum was not sampled and stood in at 0 m, so a partly visible arrow could hide, point at the wrong place or vanish behind the eye. Such points are sampled again within the 32-sample budget and the one-second retry, as on main; lone points outside the view still skip sampling. The 0 m stand-in exceptions are removed. Also from review: shared viewPlanes for transit and the renderer, a −430..9000 m segment test against the view planes, tighter tests and shorter docs.
This commit is contained in:
1 parent
95aa7ae29e
commit
fdf7ed93ce
7 files changed
+408
-265
No files matched your search
+8
-10
@@ -178,16 +178,14 @@ voice follow-ups match on them and bikeshare uses the raw station name as its
|
||||
ID. The text is still untrusted: normalization does not prevent prompt
|
||||
injection.
|
||||
|
||||
Screen annotations skip hidden records and, before surface sampling, reject an
|
||||
unsettled anchor only when its whole accepted height range (-430 to 9000 m) is
|
||||
behind the camera or below the globe horizon; a settled height is tested as the
|
||||
actual point. Anchors outside the conservative frustum do not sample and still
|
||||
project at their cached or zero height, without the horizon test that this
|
||||
stand-in height cannot decide, so a partly visible arrow keeps its connector.
|
||||
Unresolved visible heights share a 32-sample budget per projection pass (each
|
||||
board change and each rendered frame runs one), served oldest-refused first,
|
||||
retry at most once per second per anchor, and retain no extra timer or
|
||||
listener. Validated heights remain settled in the bounded cache.
|
||||
`src/annotations/screenAnnotationRenderer.js` does not sample the surface
|
||||
height under an anchor whose whole accepted height range (-430 to 9000 m) is
|
||||
behind the camera or below the globe horizon; such an anchor is hidden. A lone
|
||||
point whose range lies outside one plane of the view frustum is not sampled
|
||||
either. Points of arrows, routes and areas are sampled even outside the view,
|
||||
so the visible part of a mark runs to their real height. Until sampled, a point
|
||||
is projected at 0 m. At most 32 samples run per `projectAll()` pass,
|
||||
oldest-refused first, and each anchor retries a miss at most once a second.
|
||||
|
||||
Terrain height requests accept at most 64 points, matching the browser service's
|
||||
existing batch size and one bounded upstream chunk. Larger requests return HTTP
|
||||
|
||||
Reference in new issue
Block a user