mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
fix(street-level): four regressions from the merge review
- The selected sequence is drawn past the per-tile caps again, and its highlight takes every loaded part, drawn or not: in a dense tile a clicked Mapillary or Panoramax line kept its cones but lost its line. - photoViewer tries :fullscreen and :popover-open one at a time, each in its own try: Safari before 16.4 parses neither, and the fallback threw on every flat KartaView or Panoramax photo. - A lit Street View off Google 3D says it needs the Google 3D map again, instead of "every provider is switched off". - Chips carry their provider colour again (--chip-color, as on main). Each comes with the test that reproduced it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
4e2e0d6900
commit
fb777c1c93
9 files changed
+157
-17
No files matched your search
@@ -162,18 +162,27 @@ export function createLineCoverage({
|
||||
/**
|
||||
* A tile's sequences, filtered then capped: capping first could leave a
|
||||
* dense tile of newer flat captures with no 360° lines at all. A line past
|
||||
* the point budget is skipped; a shorter one may still fit.
|
||||
* the point budget is skipped; a shorter one may still fit. The selected
|
||||
* sequence is the answer to a click: it is drawn whatever the caps leave
|
||||
* out, and not counted against them.
|
||||
*/
|
||||
function drawnSequences(entry) {
|
||||
const drawn = [];
|
||||
const current = filter();
|
||||
const selectedId = state.sequence.selectedId ?? null;
|
||||
let points = 0;
|
||||
let counted = 0;
|
||||
for (const sequence of entry.sequenceList) {
|
||||
if (drawn.length >= perTileSequenceCap) break;
|
||||
if (!passes(sequence, current)) continue;
|
||||
if (sequence.id === selectedId) {
|
||||
drawn.push(sequence);
|
||||
continue;
|
||||
}
|
||||
if (counted >= perTileSequenceCap) continue;
|
||||
const size = pointsOf(sequence);
|
||||
if (points + size > perTilePointCap) continue;
|
||||
points += size;
|
||||
counted++;
|
||||
drawn.push(sequence);
|
||||
}
|
||||
return drawn;
|
||||
@@ -207,9 +216,14 @@ export function createLineCoverage({
|
||||
state.coverage.highlight = null;
|
||||
}
|
||||
if (!sequenceId || !scene) return;
|
||||
// From every loaded line, drawn or not: a sequence selected after its
|
||||
// tiles were drawn may have been left out by their caps.
|
||||
const current = filter();
|
||||
const parts = [];
|
||||
for (const entry of state.coverage.tiles.values())
|
||||
parts.push(...(entry.sequences.get(sequenceId)?.parts || []));
|
||||
for (const entry of state.coverage.tiles.values()) {
|
||||
const sequence = entry.sequenceList.find(({ id }) => id === sequenceId);
|
||||
if (sequence && passes(sequence, current)) parts.push(...sequence.parts);
|
||||
}
|
||||
const instances = lineInstances(
|
||||
[{ id: sequenceId, parts }],
|
||||
Cesium.Color.fromCssColorString(colors.selected),
|
||||
|
||||
Reference in new issue
Block a user