mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-20 02:02:21 +00:00
Vue kit: the command dock's and Context's buttons and glyphs are kit controls
The command dock's six style buttons, its two tray toggles, Location's collapse and the search toggle are ghost UiButtons. The style buttons are pressed toggles with `active` as their pressed class (Normal is pressed until a style is published), so they now carry aria-pressed. The Context panel's two tabs, Contacts, the cockpit entry and SEARCH NEARBY SITES are ghost UiButtons; the tabs and Contacts stay role="tab" controls with aria-selected and their own active class. The view context it shows while nothing is picked (an off layer's worldwide tile, an item's row, the place and layer chips and Ask GEV) is on the kit too; the worldwide tile is a div or a UiButton rather than a dynamic component. Every Material glyph in the three templates is a UiIcon with :size="null", so the site rules still size them; an item's motion glyph keeps role="img" and its name, with the kit's aria-hidden taken off. src/ui/kit/commandDockControls.test.mjs pins it; the markup tests that matched the old button source or class text read the kit's markup, and docs/VUE-MIGRATION.md describes the surface. Co-authored-by: Manjunath Paparaju <[email protected]>
This commit is contained in:
1 parent
e705fdea82
commit
f9ca76df98
11 files changed
+223
-62
No files matched your search
@@ -25,12 +25,12 @@ const css = readStylesheet(new URL('../style.css', import.meta.url));
|
||||
|
||||
test('Contacts stays in the keyboard sequence and Space Missions owns its rail item', () => {
|
||||
const button = html.match(
|
||||
/<button id="global-context-flights-btn"[\s\S]*?<\/button>/,
|
||||
/<button\b[^>]*\bid="global-context-flights-btn"[\s\S]*?<\/button>/,
|
||||
)?.[0];
|
||||
assert.ok(button, 'Contacts control is missing');
|
||||
assert.match(button, /role="tab"/);
|
||||
assert.match(button, /tabindex="0"/);
|
||||
const tag = contextView.match(/<button id="global-context-flights-btn"[^>]*>/)?.[0];
|
||||
const tag = contextView.match(/<UiButton id="global-context-flights-btn"[^>]*>/)?.[0];
|
||||
assert.ok(tag, 'Contacts control is missing from the view');
|
||||
assert.doesNotMatch(tag, /:tabindex|:disabled|\sdisabled/);
|
||||
assert.doesNotMatch(html, /id="global-context-missions-btn"/);
|
||||
@@ -111,7 +111,7 @@ test('Context async action buttons remain focused while busy', () => {
|
||||
assert.match(init, /if \(this\._installationsSearchBusy\) return;/);
|
||||
assert.doesNotMatch(init, /\.disabled\s*=\s*true/);
|
||||
const search = contextView.match(
|
||||
/<button id="installations-search-btn"[^>]*>/,
|
||||
/<UiButton id="installations-search-btn"[^>]*>/,
|
||||
)?.[0];
|
||||
assert.ok(search, 'nearby sites search is missing');
|
||||
assert.doesNotMatch(search, /:disabled|\sdisabled/);
|
||||
|
||||
Reference in new issue
Block a user