mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-18 01:02:23 +00:00
fix(voice): a missing-key error keeps its wording and hides the microphone hint after a language change (#1599)
The voice error was matched against the translated key message to decide whether to show the microphone hint, so switching language brought the hint back and left the message in the old language. The error now carries a missing-key flag into the status, which words the message at render time. A controller test covers the language switch, and CURRENT-STATE.md documents the keyless voice response.
This commit is contained in:
1 parent
0687e0e3da
commit
f86b8954f6
4 files changed
+48
-6
No files matched your search
@@ -407,7 +407,14 @@ export class GevRealtimeController extends RealtimeFacade {
|
||||
}
|
||||
}
|
||||
|
||||
setStatus(status, detail) {
|
||||
/**
|
||||
* @param {string} status
|
||||
* @param {string} [detail]
|
||||
* @param {{missingKey?: boolean}} [options] True when the error is a
|
||||
* missing server key: it is worded in the current language and shown
|
||||
* without the microphone hint.
|
||||
*/
|
||||
setStatus(status, detail, { missingKey = false } = {}) {
|
||||
this.status = status;
|
||||
this.emitSessionEvent({ type: 'state', state: status, detail });
|
||||
this.ui.update('root', {
|
||||
@@ -435,11 +442,12 @@ export class GevRealtimeController extends RealtimeFacade {
|
||||
this.ui.update('error', {
|
||||
text: () =>
|
||||
status === 'error'
|
||||
? resolvedDetail() || t('Voice session could not be started.')
|
||||
? (missingKey && missingVoiceKeyText()) ||
|
||||
resolvedDetail() ||
|
||||
t('Voice session could not be started.')
|
||||
: '',
|
||||
// "Check microphone permission" is wrong advice for a missing key.
|
||||
hint: () =>
|
||||
!(status === 'error' && resolvedDetail() === missingVoiceKeyText()),
|
||||
hint: () => !(status === 'error' && missingKey),
|
||||
});
|
||||
if (status === 'idle' || status === 'connecting' || status === 'error') {
|
||||
this.setVoiceSpeaker('idle');
|
||||
|
||||
Reference in new issue
Block a user