mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Place the stub's camera exactly from a direction and up
The contract places a view given as direction and up exactly, but the stub turned it into heading, pitch and roll first, so a thousand small turns straight down drifted by a hundredth. The new check camera.setView.exact holds the stub and Cesium to it; both pass.
This commit is contained in:
1 parent
ac0496a785
commit
f834903950
2 files changed
+72
-2
No files matched your search
@@ -302,10 +302,32 @@ export function createStubCamera({
|
||||
};
|
||||
}
|
||||
|
||||
/**
|
||||
* The eye at `destination` (world), looking along `orientation.direction`
|
||||
* with `up` made square to it: exactly, not through heading, pitch and
|
||||
* roll, so step moves sent many times over do not drift.
|
||||
*/
|
||||
function placeExactly(destination, orientation) {
|
||||
const d = normalize(inverseFrameVector(frame, orientation.direction));
|
||||
const u0 = inverseFrameVector(frame, orientation.up);
|
||||
position = inverseFramePoint(frame, destination);
|
||||
direction = d;
|
||||
up = normalize(sub(u0, scale(d, dot(u0, d))));
|
||||
right = cross(direction, up);
|
||||
}
|
||||
|
||||
function setView({ destination, orientation } = {}) {
|
||||
command('setView');
|
||||
const resolved = resolveDestination(destination, orientation);
|
||||
placeAt(resolved.destination, resolved.angles);
|
||||
if (orientation && 'direction' in orientation) {
|
||||
const target =
|
||||
destination && !('rect' in destination)
|
||||
? toEcef(destination)
|
||||
: resolveDestination(destination, orientation).destination;
|
||||
placeExactly(target, orientation);
|
||||
} else {
|
||||
const resolved = resolveDestination(destination, orientation);
|
||||
placeAt(resolved.destination, resolved.angles);
|
||||
}
|
||||
requestRender('camera');
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user