fix(osm): stop using public Overpass by default (#648) (#742)

Traffic roads come from OpenFreeMap vector tiles, or TomTom flow tiles with a
key (Hybrid by default). Military areas use OpenFreeMap polygons with a bundled
worldwide name index; wide views show named points. ALPR reads an hourly
OpenStreetMap extract. Cockpit place context and country, state and US county
outlines use bundled Natural Earth and US Census data. Overpass is used only
when an operator configures their own endpoint.

Also: camera arrivals no longer land below ground, keyless terrain retries on
429, bounded relation geometry for configured Overpass, one shared
OpenStreetMap credit, and separate tile and API transports for embedders.

Co-authored-by: theGaryLarson <[email protected]>
Co-authored-by: Milan Khanal <[email protected]>

src/layers/awareness/anchor.test.mjs

@@ -0,0 +1,61 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import * as Cesium from 'cesium';
+import { createControls } from './controls.js';
+import { createSubject } from './subject.js';
+
+test('passive Contacts releases its installation anchor and subject refresh cannot reclaim it', (t) => {
+  const prior = globalThis.document;
+  globalThis.document = { body: { classList: { contains: () => false } } };
+  t.after(() => {
+    globalThis.document = prior;
+  });
+  const anchors = [];
+  const position = Cesium.Cartesian3.fromDegrees(-117.14, 32.87);
+  const state = {
+    enabled: true,
+    passive: false,
+    subject: {
+      id: 'site',
+      layerId: 'military-installations',
+      label: 'Site',
+      position,
+    },
+    sourceRevision: 'current',
+    lastEvaluatedPosition: position,
+    results: {},
+  };
+  const services = {
+    installations: { setContextAnchor: (value) => anchors.push(value) },
+  };
+  let activations = 0;
+  const parts = {
+    dependencies: { activateOperationalContext: () => activations++ },
+    queries: {
+      collectSourceStates: () => ({}),
+      sourceRevision: () => 'current',
+    },
+    navigation: { isFlightLayer: () => false },
+    model: { awarenessRefreshRequired: () => false },
+    rendering: { renderVisual() {}, scheduleDirectionOverlayUpdate() {} },
+  };
+  const controls = createControls({ state, services, parts }).methods;
+  const subject = createSubject({ state, services, parts });
+  subject.refreshSelectedSubject();
+  assert.equal(anchors.length, 1);
+  assert.ok(anchors[0] instanceof Cesium.Cartesian3);
+  controls.setParams({ passive: true });
+  assert.equal(anchors.at(-1), null);
+  const released = anchors.length;
+  subject.refreshSelectedSubject();
+  subject.refreshSelectedSubject();
+  assert.equal(
+    anchors.length,
+    released,
+    'passive refresh must not reclaim the viewport',
+  );
+  controls.setParams({ passive: false });
+  assert.equal(activations, 1);
+  subject.refreshSelectedSubject();
+  assert.ok(anchors.at(-1) instanceof Cesium.Cartesian3);
+});

src/layers/awareness/controls.js

@@ -29,6 +29,7 @@ export function createControls({ state: layerState, services, parts, source }) {
       if (typeof params.passive !== 'boolean') return;
       const wasPassive = layerState.passive;
       layerState.passive = params.passive;
+      if (layerState.passive) services.installations?.setContextAnchor?.(null);
       if (layerState.enabled && wasPassive && !layerState.passive)
         parts.dependencies.activateOperationalContext();
     },

src/layers/awareness/lifecycle.js

@@ -206,6 +206,7 @@ export function createLifecycle({
       layerState.autoFocusAttempted = false;
       layerState.autoFocusRetryPending = false;
       layerState.subject = null;
+      services.installations?.setContextAnchor?.(null);
       layerState.results = null;
       layerState.lastSubjectRefreshMs = 0;
       layerState.lastEvaluatedPosition = null;

src/layers/awareness/panel.js

@@ -72,7 +72,7 @@ export function createPanel({ state: layerState, services, parts, source }) {
           return `<li><span class="military-awareness-target unavailable" aria-label="Unavailable">${escapeHtml(label)} <span>${formatAwarenessDistance(item.distanceM)}</span></span></li>`;
         }
         const accessibleLabel = label === '—' ? 'Unavailable' : label;
-        return `<li><button type="button" class="military-awareness-target" data-awareness-layer="${escapeHtml(cohort.id)}" data-awareness-id="${escapeHtml(targetId)}" aria-label="Focus ${escapeHtml(accessibleLabel)}">${escapeHtml(label)} <span>${formatAwarenessDistance(item.distanceM)}</span></button></li>`;
+        return `<li><button type="button" class="military-awareness-target" data-awareness-layer="${escapeHtml(cohort.id)}" data-awareness-id="${escapeHtml(targetId)}" aria-label="Focus ${escapeHtml(accessibleLabel)}">${escapeHtml(label)} <span>${formatAwarenessDistance(item.distanceM)}</span></button>${namedAreasHtml(item.memberNames)}</li>`;
       })
       .join('');
     const pageCount = Math.max(
@@ -164,11 +164,18 @@ export function createPanel({ state: layerState, services, parts, source }) {
     );
   }
 
+  function namedAreasHtml(names) {
+    return names?.length
+      ? `<details class="military-awareness-names"><summary>Named areas (${names.length})</summary><div>${names.map((name) => escapeHtml(name)).join('<br>')}</div></details>`
+      : '';
+  }
+
   function renderResults() {
     if (!layerState.enabled || !layerState.results) return hidePanel();
     const panel = ensurePanel();
     const { subject, cohorts } = layerState.results;
     const markup = `<div class="military-awareness-subject">${escapeHtml(subject.label)} · ${formatAwarenessDistance(AWARENESS_RADIUS_M)} FLIGHT / VESSEL WINDOW</div>
+    ${namedAreasHtml(subject.memberNames)}
     ${navigationControlsHtml()}
     ${cohorts.map(rowHtml).join('')}
     <p class="military-awareness-note" tabindex="-1" data-awareness-focus-continuation>Open-source mapped/observed context. Missing broadcasts, unloaded map areas, or unmapped sites are not evidence of absence.</p>`;

src/layers/awareness/queries.js

@@ -94,14 +94,33 @@ export function createQueries({ state: layerState, services, parts, source }) {
    */
 
   function summarizeInstallationViewport(items, source) {
+    const coverage = source.stats?.coverage;
+    // getNearby measures these distances from the current subject, independent
+    // of the retained square used to fetch installation tiles.
+    const withinRadius =
+      coverage?.kind === 'subject' && Number.isFinite(coverage.radiusM)
+        ? items.filter(
+            (item) => (item.distanceM ?? item.distance) <= coverage.radiusM,
+          )
+        : items;
     const summary = parts.navigation.summarizeAwarenessCohortForNavigation(
-      items,
+      withinRadius,
       source,
     );
     if (summary.count === null)
       return source.stats?.statusMessage
         ? { ...summary, reason: source.stats.statusMessage }
         : summary;
+    // A subject window is its own bounded area: name it instead of the viewport.
+    if (coverage?.kind === 'subject' && Number.isFinite(coverage.radiusM)) {
+      const km = Math.round(coverage.radiusM / 1000);
+      return {
+        ...summary,
+        reason: summary.count
+          ? `mapped matches within ${km} km of the subject`
+          : `none mapped within ${km} km; not a complete 250 km survey`,
+      };
+    }
     return {
       ...summary,
       reason: summary.count

src/layers/awareness/queries.test.mjs

@@ -0,0 +1,50 @@
+import test from 'node:test';
+import assert from 'node:assert/strict';
+import * as Cesium from 'cesium';
+import { createQueries } from './queries.js';
+import { createSubject } from './subject.js';
+import { createControls } from '../installations/controls.js';
+import { createModel } from '../installations/model.js';
+import { summarizeAwarenessCohort } from '../../data/militaryAwarenessEngine.js';
+
+test('Contacts excludes square corners and measures from the current moving subject', () => {
+  const records = [
+    { id: 'corner', kind: 'installation', latitude: 90 / 111.195, longitude: 90 / 111.195 },
+    { id: 'east', kind: 'installation', latitude: 0, longitude: 90 / 111.195 },
+    { id: 'west', kind: 'installation', latitude: 0, longitude: -90 / 111.195 },
+  ];
+  const installationState = { records, contextAnchor: { latitude: 0, longitude: 0 },
+    lastUpdate: 1, status: 'ready', coverage: { kind: 'subject', radiusM: 100000 },
+    distanceEndpointScratch: new Cesium.Cartographic(),
+    distanceGeodesicScratch: new Cesium.EllipsoidGeodesic(),
+  };
+  const installationParts = { rendering: { installationSurfaceHeightM: () => 0 } };
+  installationParts.model = createModel({ state: installationState, parts: installationParts });
+  const installations = createControls({ state: installationState, parts: installationParts }).methods;
+  const services = { installations, flights: { getNearby: () => [] },
+    military: { getNearby: () => [] }, vessels: { getNearby: () => [] } };
+  const parts = { navigation: { summarizeAwarenessCohortForNavigation: (items, source) =>
+    summarizeAwarenessCohort(items, source) } };
+  parts.queries = createQueries({ state: {}, services, parts });
+  const subjectOwner = createSubject({ state: {}, services, parts });
+  const states = Object.fromEntries(['flights', 'military', 'ais-live-vessels', 'military-installations']
+    .map((id) => [id, { available: true, stats: {} }]));
+  states['military-installations'].stats.coverage = { kind: 'subject', radiusM: 100000 };
+  const evaluate = (lon) => subjectOwner.evaluateSubject({
+    id: 'moving', layerId: 'flights', position: Cesium.Cartesian3.fromDegrees(lon, 0, 10000),
+  }, states).cohorts[3].summary;
+  installations.setContextAnchor({ latitude: 0, longitude: 0 });
+  const first = evaluate(0);
+  assert.equal(first.count, 2);
+  assert.ok(!first.nearest.some((item) => item.id === 'corner'), '90 km N + 90 km E is outside the disk');
+  assert.equal(installations.getStats().count, 2);
+  assert.equal(installations.getStats().statusMessage, '2 mapped sites within 100 km of the contact');
+  installations.setContextAnchor({ latitude: 0, longitude: 19 / 111.195 });
+  const moved = evaluate(19 / 111.195);
+  assert.equal(installations.getStats().count, 1);
+  assert.equal(installations.getStats().statusMessage, '1 mapped site within 100 km of the contact');
+  assert.equal(moved.count, 1, 'west site leaves the radius before the fetch anchor refreshes');
+  assert.equal(moved.nearest[0].id, 'east');
+  assert.equal(moved.reason, 'mapped matches within 100 km of the subject');
+  assert.deepEqual(installationState.contextAnchor, { latitude: 0, longitude: 0 });
+});

src/layers/awareness/subject.js

@@ -48,8 +48,13 @@ export function createSubject({ state: layerState, services, parts, source }) {
         (item) =>
           !parts.queries.isSame(subject, item, 'ais-live-vessels', 'mmsi'),
       );
+    const coverage = installationsState.stats?.coverage;
+    const installationRadius =
+      coverage?.kind === 'subject' && Number.isFinite(coverage.radiusM)
+        ? coverage.radiusM
+        : AWARENESS_RADIUS_M;
     const installations = militaryInstallationsLayer
-      .getNearby(position, AWARENESS_RADIUS_M, AWARENESS_QUERY_LIMIT)
+      .getNearby(position, installationRadius, AWARENESS_QUERY_LIMIT)
       .filter(
         (item) =>
           !parts.queries.isSame(subject, item, 'military-installations', 'id'),
@@ -92,7 +97,8 @@ export function createSubject({ state: layerState, services, parts, source }) {
           source:
             installationsState.stats.source ||
             SOURCE_LABEL['military-installations'],
-          coverage: 'CURRENT VIEWPORT ONLY',
+          coverage:
+            installationsState.stats.coverageLabel || 'CURRENT VIEWPORT ONLY',
           summary: parts.queries.summarizeInstallationViewport(
             installations,
             installationsState,
@@ -326,6 +332,11 @@ export function createSubject({ state: layerState, services, parts, source }) {
     });
     if (!resolved) return;
     const { position, presence } = resolved;
+    // Mapped installations load around the subject, not the (follow/Cockpit)
+    // camera view. The installation layer moves its window only after the
+    // subject travels far enough, so this per-refresh call is cheap.
+    if (!layerState.passive)
+      militaryInstallationsLayer.setContextAnchor?.(position);
     // UNCHECKED leaves the verdict alone: this tick simply did not look.
     if (presence === SUBJECT_PRESENCE.LIVE) layerState.subjectMissing = false;
     else if (presence === SUBJECT_PRESENCE.MISSING)
@@ -392,6 +403,7 @@ export function createSubject({ state: layerState, services, parts, source }) {
       layerId: record.layerId,
       id: record.properties?.mmsi || record.id,
       label: record.label || record.id,
+      memberNames: record.properties?.memberNames || [],
       position: Cesium.Cartesian3.fromDegrees(longitude, latitude, 0),
     };
   }
@@ -411,6 +423,7 @@ export function createSubject({ state: layerState, services, parts, source }) {
   }
 
   function clearAwarenessSubject() {
+    militaryInstallationsLayer.setContextAnchor?.(null);
     layerState.autoFocusRetryPending = false;
     layerState.subject = null;
     layerState.subjectMissing = false;