mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-20 10:12:18 +00:00
Hand features the engine instead of guessing it from a viewer
No code outside src/globe calls isGlobeEngine or engineFromViewer any more (14 calls left before this). The features that still sniffed take the engine from their caller: - Projection and surface helpers (focus de-emphasis, icon orientation, ground snap, the mesh floor sampler, ground picks) take the engine; the engine view's scene carries its projector instead of registering itself as a viewer. - Credits go only through engine.credits, so annotations and layers share one OSM credit state on Cesium too (it could show twice). - The annotation board and the resolver work on the engine: camera assists, visibility and picks go through engine.camera, engine.projector and src/geo, without Cesium. - The Recent Imagery box tool has one implementation for both engines, on capture-phase canvas pointer events with the layer's engine.ground preview; the Navara copy goes. On Cesium the preview outline is solid now, as on Navara. - Scene interactions take the engine, and the render governor has an engine variant beside the Cesium one. Remaining engine-specific features stay behind explicit seams until the contract covers them: the draw tool's Cesium surface (stock click actions cannot be suspended), the annotation drapes (animated materials), share follow, Cesium post effects and cyber sonar, and data packs (meshes). Coupling: Cesium-importing files fall from 31 to 27, `viewer` lines from 1367 to 1234, engine sniffing calls from 14 to 0.
This commit is contained in:
1 parent
406dd9122e
commit
f1ec9d4a22
61 files changed
+823
-1230
No files matched your search
@@ -2,6 +2,7 @@ import { test, beforeEach } from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import {
|
||||
installRenderGovernor,
|
||||
installEngineRenderGovernor,
|
||||
holdContinuousRender,
|
||||
releaseContinuousRender,
|
||||
governorRequestRender,
|
||||
@@ -118,7 +119,7 @@ test('on a non-Cesium globe engine the governor drives engine.render with owner-
|
||||
_resetRenderGovernorForTest();
|
||||
const engine = createFakeEngine({ kind: 'navara' });
|
||||
holdContinuousRender('before-install');
|
||||
installRenderGovernor(engine);
|
||||
installEngineRenderGovernor(engine);
|
||||
assert.equal(engine.render.isContinuous(), true, 'a hold taken before install applies');
|
||||
releaseContinuousRender('before-install');
|
||||
assert.equal(engine.render.isContinuous(), false);
|
||||
@@ -141,7 +142,7 @@ test('releasing an absent Navara hold does not wake an already idle engine', asy
|
||||
const { createFakeEngine } = await import('./globe/testing/fakeEngine.js');
|
||||
_resetRenderGovernorForTest();
|
||||
const engine = createFakeEngine({ kind: 'navara' });
|
||||
installRenderGovernor(engine);
|
||||
installEngineRenderGovernor(engine);
|
||||
engine.fake.resetCalls();
|
||||
for (let i = 0; i < 22; i++) releaseContinuousRender('cctv-projection');
|
||||
assert.equal(engine.fake.callsOf('render.request').length, 0);
|
||||
|
||||
Reference in new issue
Block a user