mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-21 18:52:18 +00:00
Hand features the engine instead of guessing it from a viewer
No code outside src/globe calls isGlobeEngine or engineFromViewer any more (14 calls left before this). The features that still sniffed take the engine from their caller: - Projection and surface helpers (focus de-emphasis, icon orientation, ground snap, the mesh floor sampler, ground picks) take the engine; the engine view's scene carries its projector instead of registering itself as a viewer. - Credits go only through engine.credits, so annotations and layers share one OSM credit state on Cesium too (it could show twice). - The annotation board and the resolver work on the engine: camera assists, visibility and picks go through engine.camera, engine.projector and src/geo, without Cesium. - The Recent Imagery box tool has one implementation for both engines, on capture-phase canvas pointer events with the layer's engine.ground preview; the Navara copy goes. On Cesium the preview outline is solid now, as on Navara. - Scene interactions take the engine, and the render governor has an engine variant beside the Cesium one. Remaining engine-specific features stay behind explicit seams until the contract covers them: the draw tool's Cesium surface (stock click actions cannot be suspended), the annotation drapes (animated materials), share follow, Cesium post effects and cyber sonar, and data packs (meshes). Coupling: Cesium-importing files fall from 31 to 27, `viewer` lines from 1367 to 1234, engine sniffing calls from 14 to 0.
This commit is contained in:
1 parent
406dd9122e
commit
f1ec9d4a22
61 files changed
+823
-1230
No files matched your search
@@ -746,13 +746,12 @@ test('the perspective helper is continuous through the sub-pixel band, not a 23
|
||||
);
|
||||
});
|
||||
|
||||
test('the exact projection asks the engine projector of a registered scene', async () => {
|
||||
test('the exact projection asks the engine projector its scene carries', async () => {
|
||||
const geo = await import('../geo/index.js');
|
||||
const { registerViewerEngine } = await import('../globe/cesium/engineFromViewer.js');
|
||||
const { perspectiveProjectedRotation: rotation } = await import('./iconOrientation.js');
|
||||
const scene = { camera: { rightWC: { x: 0, y: 1, z: 0 }, upWC: { x: 0, y: 0, z: 1 } } };
|
||||
const asked = [];
|
||||
const unregister = registerViewerEngine({ scene }, {
|
||||
const scene = {
|
||||
camera: { rightWC: { x: 0, y: 1, z: 0 }, upWC: { x: 0, y: 0, z: 1 } },
|
||||
projector: {
|
||||
// Screen-right for every point further east (the probe), so 90° on screen.
|
||||
worldToWindow(position, result = geo.cartesian2.create()) {
|
||||
@@ -760,12 +759,8 @@ test('the exact projection asks the engine projector of a registered scene', asy
|
||||
return Object.assign(result, { x: asked.length === 1 ? 100 : 120, y: 100 });
|
||||
},
|
||||
},
|
||||
});
|
||||
try {
|
||||
const value = rotation(scene, geo.cartesian3.fromDegrees(0, 0, 0), 90, null);
|
||||
assert.equal(asked.length, 2, 'the anchor and the probe');
|
||||
assert.ok(Math.abs(value - -Math.PI / 2) < 1e-9, `rotation ${value}`);
|
||||
} finally {
|
||||
unregister();
|
||||
}
|
||||
};
|
||||
const value = rotation(scene, geo.cartesian3.fromDegrees(0, 0, 0), 90, null);
|
||||
assert.equal(asked.length, 2, 'the anchor and the probe');
|
||||
assert.ok(Math.abs(value - -Math.PI / 2) < 1e-9, `rotation ${value}`);
|
||||
});
|
||||
Reference in new issue
Block a user