Hand features the engine instead of guessing it from a viewer

No code outside src/globe calls isGlobeEngine or engineFromViewer any
more (14 calls left before this). The features that still sniffed take
the engine from their caller:

- Projection and surface helpers (focus de-emphasis, icon orientation,
  ground snap, the mesh floor sampler, ground picks) take the engine; the
  engine view's scene carries its projector instead of registering itself
  as a viewer.
- Credits go only through engine.credits, so annotations and layers
  share one OSM credit state on Cesium too (it could show twice).
- The annotation board and the resolver work on the engine: camera
  assists, visibility and picks go through engine.camera,
  engine.projector and src/geo, without Cesium.
- The Recent Imagery box tool has one implementation for both engines,
  on capture-phase canvas pointer events with the layer's engine.ground
  preview; the Navara copy goes. On Cesium the preview outline is solid
  now, as on Navara.
- Scene interactions take the engine, and the render governor has an
  engine variant beside the Cesium one.

Remaining engine-specific features stay behind explicit seams until the
contract covers them: the draw tool's Cesium surface (stock click actions
cannot be suspended), the annotation drapes (animated materials), share
follow, Cesium post effects and cyber sonar, and data packs (meshes).

Coupling: Cesium-importing files fall from 31 to 27, `viewer` lines
from 1367 to 1234, engine sniffing calls from 14 to 0.
This commit is contained in:
German Khokhlov committed 2026-11-07 08:46:30 +04:00
1 parent 406dd9122e
commit f1ec9d4a22
61 files changed
+823 -1230

No files matched your search

+5 -5
View File
@@ -47,7 +47,7 @@ test('the marks survive a globe leaving and are drawn again on the next one', as
withAnimationFrames(t);
const log = [];
const engine = createAnnotationEngine({
viewer: {},
globe: {},
renderer: recordingRenderer(log, 'cesium'),
resolveTarget: async () => ({ ...BUILDING }),
});
@@ -69,7 +69,7 @@ test('the marks survive a globe leaving and are drawn again on the next one', as
log.length = 0;
engine.attachRenderer({
viewer: {},
engine: {},
renderer: recordingRenderer(log, 'next'),
});
assert.deepEqual(log, ['next add Capitol']);
@@ -83,13 +83,13 @@ test('detaching twice and attaching over an attached globe release each drawing
withAnimationFrames(t);
const log = [];
const engine = createAnnotationEngine({
viewer: {},
globe: {},
renderer: recordingRenderer(log, 'a'),
});
engine.detachRenderer();
engine.detachRenderer();
engine.attachRenderer({ viewer: {}, renderer: recordingRenderer(log, 'b') });
engine.attachRenderer({ viewer: {}, renderer: recordingRenderer(log, 'c') });
engine.attachRenderer({ engine: {}, renderer: recordingRenderer(log, 'b') });
engine.attachRenderer({ engine: {}, renderer: recordingRenderer(log, 'c') });
assert.deepEqual(log, ['a destroy', 'b destroy']);
engine.destroy();
});