mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-05 02:44:02 +00:00
Clean up the panel after host testing
Drop the render restarts added while chasing the black overlays; keep the full render-error report and stop the timer after an error, as Cesium does. Correct comments the investigation outran, share the panel_request name, and document the host differences the panel works around.
This commit is contained in:
1 parent
d0da4b0722
commit
efdee8d255
6 files changed
+43
-53
No files matched your search
+3
-13
@@ -49,8 +49,6 @@ export function isEmbeddedInline() {
|
||||
// frames; see keepPanelRendering.
|
||||
const PANEL_FRAME_MS = 33;
|
||||
const MISSED_FRAMES_MS = 250;
|
||||
const RENDER_RESTARTS = 3;
|
||||
const RENDER_RESTART_MS = 1000;
|
||||
|
||||
/** A render error's details, including the plain objects workers report. */
|
||||
function describeError(error) {
|
||||
@@ -80,11 +78,10 @@ export function keepPanelRendering(
|
||||
frameRequest = windowRef.requestAnimationFrame(onFrame);
|
||||
};
|
||||
frameRequest = windowRef.requestAnimationFrame(onFrame);
|
||||
// Cesium stops drawing after a render error. Report it in full, and
|
||||
// start again a few times in case it does not repeat.
|
||||
// Cesium stops drawing after a render error, and so does the timer.
|
||||
// Report the error in full: workers report plain objects, which Cesium
|
||||
// prints as [object Object].
|
||||
let failed = false;
|
||||
let restarts = 0;
|
||||
let restart = null;
|
||||
const removeErrorListener = viewer.scene?.renderError?.addEventListener(
|
||||
(_scene, error) => {
|
||||
failed = true;
|
||||
@@ -92,12 +89,6 @@ export function keepPanelRendering(
|
||||
"[God's Eye View panel] render error:",
|
||||
describeError(error),
|
||||
);
|
||||
if (restarts >= RENDER_RESTARTS) return;
|
||||
restarts += 1;
|
||||
restart = windowRef.setTimeout(() => {
|
||||
failed = false;
|
||||
viewer.useDefaultRenderLoop = true;
|
||||
}, RENDER_RESTART_MS);
|
||||
},
|
||||
);
|
||||
const timer = windowRef.setInterval(() => {
|
||||
@@ -112,7 +103,6 @@ export function keepPanelRendering(
|
||||
}, PANEL_FRAME_MS);
|
||||
return () => {
|
||||
windowRef.clearInterval(timer);
|
||||
windowRef.clearTimeout?.(restart);
|
||||
windowRef.cancelAnimationFrame(frameRequest);
|
||||
removeErrorListener?.();
|
||||
};
|
||||
|
||||
Reference in new issue
Block a user