mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-19 01:32:19 +00:00
Tighten the render failure notice's error handling and focus
- An error a frame of the inline panel's timer throws no longer reaches the host page; it has been raised as a render error by then. - An error Scene raised and threw on (rethrowRenderErrors) is raised once. - After a lost context, later render errors are only logged, so the notice keeps saying why. - A render error without a value shows no detail. - The globe's tile load progress and the scene's tileset load events are finished too when a listener's error cuts them short. - Focus goes back where it was when the globe draws again, or to the map. - The appearance counter and the guard for a missing viewer are gone. Tests cover every finished event, a thrown timer frame, a single report under rethrowRenderErrors and the focus return; the inline tests share one setup.
This commit is contained in:
1 parent
265074aa54
commit
ebaa439739
12 files changed
+459
-416
No files matched your search
@@ -35,10 +35,9 @@ export const useStatusStore = defineStore('gev-status', () => {
|
||||
const fps = shallowRef(null);
|
||||
|
||||
/**
|
||||
* The globe's render failure, `{reason, detail, shown, retry, reset}`; null
|
||||
* while the globe draws. `reason` is 'render-error' or 'context-lost',
|
||||
* `shown` changes each time the notice appears, and `retry` and `reset` are
|
||||
* null where that action is not offered.
|
||||
* The globe's render failure, `{reason, detail, retry, reset}`; null while
|
||||
* the globe draws. `reason` is 'render-error' or 'context-lost', and `retry`
|
||||
* and `reset` are null where that action is not offered.
|
||||
*/
|
||||
const renderFailure = shallowRef(null);
|
||||
|
||||
|
||||
Reference in new issue
Block a user