Raised GeoJSON and cable polygons are lit by the sun again

The loader's entities drew a polygon with per-position heights through a
lit appearance; through the draw port it went flat. Local GeoJSON and
submarine cable fills with heights pass lit: true, as file import does.
This commit is contained in:
Sameh Khamis committed 2026-11-13 23:59:19 -08:00
1 parent af3383a5a9
commit ea3b87805a
4 files changed
+7

No files matched your search

+2
View File
@@ -1610,6 +1610,8 @@ const fillItem = (record) =>
// browsers, whatever `stroke-width` says. // browsers, whatever `stroke-width` says.
outlineWidth: 1, outlineWidth: 1,
height: 'absolute', height: 'absolute',
// The loader's entities drew a raised polygon lit by the sun.
lit: true,
meta: record.carrier, meta: record.carrier,
show: record.visible, show: record.visible,
} }
+2
View File
@@ -315,6 +315,8 @@ test('heights raise a polygon off the ground and stand a point’s pin on its ti
const fill = env.fake.set('raised').items.get('p'); const fill = env.fake.set('raised').items.get('p');
assert.equal(fill.height, 'absolute'); assert.equal(fill.height, 'absolute');
assert.equal(fill.geometry.perPositionHeight, true); assert.equal(fill.geometry.perPositionHeight, true);
// Lit by the sun, as the loader's entities drew a raised polygon.
assert.equal(fill.lit, true);
assert.equal(fill.geometry.rings[0][0].height, 100); assert.equal(fill.geometry.rings[0][0].height, 100);
assert.deepEqual(fill.outline, [0, 136 / 255, 1, 1]); assert.deepEqual(fill.outline, [0, 136 / 255, 1, 1]);
const pin = env.fake.set('pins').items.get('pt'); const pin = env.fake.set('pins').items.get('pt');
@@ -1272,6 +1272,7 @@ test('polygons and reference-less features draw as the GeoJSON loader drew them'
// Heights keep a polygon off the ground, outlined in its stroke. // Heights keep a polygon off the ground, outlined in its stroke.
assert.equal(fills[3].height, 'absolute'); assert.equal(fills[3].height, 'absolute');
assert.equal(fills[3].geometry.perPositionHeight, true); assert.equal(fills[3].geometry.perPositionHeight, true);
assert.equal(fills[3].lit, true);
assert.deepEqual(fills[3].outline, [0, 0, 1, 1]); assert.deepEqual(fills[3].outline, [0, 0, 1, 1]);
assert.equal(fills[3].geometry.rings[0].length, 5); assert.equal(fills[3].geometry.rings[0].length, 5);
// A feature with no reference still draws, unpicked and with no reference. // A feature with no reference still draws, unpicked and with no reference.
+2
View File
@@ -277,6 +277,8 @@ export function createRendering({ state }) {
// WebGL draws the loader's outline one pixel wide. // WebGL draws the loader's outline one pixel wide.
outline: strokeColor(props, cable, baseColor), outline: strokeColor(props, cable, baseColor),
outlineWidth: 1, outlineWidth: 1,
// The loader's entities drew a raised polygon lit by the sun.
lit: true,
} }
: { height: 'clampGround' }), : { height: 'clampGround' }),
show: true, show: true,