mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-20 02:02:21 +00:00
Street Level photo viewer: keyless ranking, closed waits, a moved canvas
Review follow-ups to the previous commit: - photoViewers.js ranks a presentation without a mountKey as mounted when it began presenting (after the latest key seen, before any later mount), so a photo viewer mounting while a keyless one shows is drawn and the keyless one superseded; supersede is queued whenever more than one presents after any change, not only when the pick changes. - A panorama's open still waiting on a draw when the last view leaves fails as closed and leaves no photo shown, instead of uploading to a canvas never drawn. A mount waiting on its first draw then also fails as closed and is unmounted, so a view subscribing later sees nothing. - A view handing back another canvas element than the renderer's drops the renderer and draws the panorama again on the new one, as after a lost context. - The guard test allows a .src write in loadImage only on the one `image` binding, created by new Image() and never rebound or shadowed, and refuses `(expr).src =` and bracket property writes anywhere. - The test fakes' shared view is reset before each test (resetPhotoView), so a viewer left by an earlier test is neither drawn with nor superseded by a later test's. Nothing changes in the running app. Co-authored-by: Manjunath Paparaju <[email protected]>
This commit is contained in:
1 parent
33ac0545ef
commit
e6f21777ba
11 files changed
+327
-50
No files matched your search
@@ -95,9 +95,22 @@ function resubscribe() {
|
||||
previous?.();
|
||||
}
|
||||
|
||||
/**
|
||||
* Start the shared view afresh, with no viewer: a test file calls it before
|
||||
* each test, so a viewer left by an earlier test is not drawn with a later
|
||||
* test's (nor superseded by it). A viewer it held is left without a view.
|
||||
*/
|
||||
export function resetPhotoView() {
|
||||
shared.generation++;
|
||||
shared.unsubscribe?.();
|
||||
shared.unsubscribe = null;
|
||||
shared.viewers.clear();
|
||||
shared.draw = null;
|
||||
}
|
||||
|
||||
/**
|
||||
* Draw a photo viewer with the shared view, alongside every other viewer
|
||||
* given here (see `shared`).
|
||||
* given here since the last `resetPhotoView()` (see `shared`).
|
||||
* @returns {() => void} Stop drawing it.
|
||||
*/
|
||||
export function drawPhotoViewer(viewer) {
|
||||
|
||||
Reference in new issue
Block a user