fix(street-level): fit the whole photo on phones

At phone width the right rail is the band between mid-screen and the credit
line, so a 16:10 viewer plus its bar and caption was cut off. Below 720 px
the viewer's height is derived from that band (clamped 110-320 px); floating
and expanded viewers reset to auto height. The QA harness checks the photo
and caption fit at 390x844, and CURRENT-STATE documents the docking rules
and phone sizing.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
Said TurkseverandClaude Opus 5.5 committed 2026-09-25 21:18:40 +01:00
1 parent 6207e4144e
commit e6c2c812f9
4 files changed
+91 -2

No files matched your search

+57
View File
@@ -621,6 +621,63 @@ async function main() {
});
},
);
await step(
'on a phone the whole photo fits in the docked panel',
async () => {
await page.setViewport({
width: 390,
height: 844,
isMobile: true,
hasTouch: true,
});
await sleep(800);
if (
await page.$eval('#street-level-panel', (node) =>
node.classList.contains('collapsed'),
)
)
await page.click(
'.panel-collapse-btn[data-collapse-target="street-level-panel"]',
);
await page.evaluate((id) => {
void window.__godsEyeView.dataManager.layers
.get('street-level')
.module.openImage('mapillary', id);
}, firstImageId);
await page.waitForFunction(
() => {
const s = window.__godsEyeView.dataManager.layers
.get('street-level')
.module.getUIState().street;
return (s.imageId && !s.loading) || s.error;
},
{ timeout: 90_000 },
);
await sleep(600);
const fit = await page.evaluate(() => {
const inner = document
.querySelector('.street-level-panel-inner')
.getBoundingClientRect();
const meta = document
.getElementById('sl-image-meta')
.getBoundingClientRect();
const viewer = document
.getElementById('sl-viewer')
.getBoundingClientRect();
return {
cut: Math.round(meta.bottom - inner.bottom),
top: Math.round(viewer.top - inner.top),
height: Math.round(viewer.height),
overflowX: document.documentElement.scrollWidth > innerWidth,
};
});
assert.ok(fit.cut <= 1, `photo and caption fit (${fit.cut}px cut)`);
assert.ok(fit.height >= 100, `viewer stays usable (${fit.height}px)`);
assert.equal(fit.overflowX, false, 'no sideways scroll');
await page.setViewport(VIEWPORTS[0]);
await sleep(600);
},
);
await step('no page errors', () => {
assert.deepEqual(errors, []);
});