benmichael/gods-eye-view
1
0 Fork 0
mirror of https://github.com/bilawalsidhu/gods-eye-view.git synced 2026-11-06 11:24:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

style(agent): apply pinned Prettier output and remove temporary probe

Browse Source 
Restore the main branch formatter unchanged and use byte-exact Prettier 3.9.6 formatting on the World Packet parity regressions.
This commit is contained in:
Kevin Rajan committed 2026-10-17 05:12:15 -05:00
1 parent f4a4df5044
commit e4f526415d
2 files changed
+73 -96
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

scripts/format.mjs
-14
View File
@@ -141,20 +141,6 @@ if (import.meta.url === invoked) {
if (mode === '--check' && result.changed.length) { if (mode === '--check' && result.changed.length) {
for (const name of result.changed) for (const name of result.changed)
console.error(`Needs formatting: ${name}`); console.error(`Needs formatting: ${name}`);
// Temporary formatter output probe for the existing #880 test only.
if (result.changed.includes('src/agent/worldPacket.test.mjs')) {
const file = path.join(
fileURLToPath(new URL('../', import.meta.url)),
'src/agent/worldPacket.test.mjs',
);
const formatted = await prettier.format(await readFile(file, 'utf8'), {
...(await prettier.resolveConfig(file)),
filepath: file,
});
const encoded = Buffer.from(formatted).toString('base64');
for (let offset = 0; offset < encoded.length; offset += 1000)
console.error(`PRETTIER-DATA|src/agent/worldPacket.test.mjs|${offset}|${encoded.slice(offset, offset + 1000)}`);
}
process.exitCode = 1; process.exitCode = 1;
} else { } else {
console.log( console.log(
src/agent/worldPacket.test.mjs
+73 -82
View File
@@ -71,94 +71,85 @@ test('World Packet preserves get_current_view_state parity', async () => {
assert.equal(packet.feedProvenance.overall, 'nominal'); assert.equal(packet.feedProvenance.overall, 'nominal');
}); });
test( test('World Packet keeps stale/unavailable feed semantics distinct from empty', () => {
'World Packet keeps stale/unavailable feed semantics distinct from empty', const { viewer, dataManager, styleManager } = harness();
() => { dataManager.getAll = () => [
const { viewer, dataManager, styleManager } = harness(); {
dataManager.getAll = () => [ id: 'traffic',
{ name: 'Traffic',
id: 'traffic', enabled: true,
name: 'Traffic', stats: {
enabled: true, count: 0,
stats: { source: 'fixture',
count: 0, error: 'fixture unavailable',
source: 'fixture', lastUpdate: null,
error: 'fixture unavailable',
lastUpdate: null,
},
}, },
]; },
];
const packet = getWorldPacket({ viewer, dataManager, styleManager }); const packet = getWorldPacket({ viewer, dataManager, styleManager });
assert.equal(packet.layers[0].count, 0); assert.equal(packet.layers[0].count, 0);
assert.notEqual(packet.layers[0].feedState, 'nominal'); assert.notEqual(packet.layers[0].feedState, 'nominal');
assert.notEqual(packet.feedProvenance.overall, 'nominal'); assert.notEqual(packet.feedProvenance.overall, 'nominal');
assert.match(packet.feedProvenance.note, /fixture unavailable/i); assert.match(packet.feedProvenance.note, /fixture unavailable/i);
}, });
);
test( test('semantic fingerprint ignores narration prose but changes with observed state', () => {
'semantic fingerprint ignores narration prose but changes with observed state', const { viewer, dataManager, styleManager } = harness();
() => { const packet = getWorldPacket({ viewer, dataManager, styleManager });
const { viewer, dataManager, styleManager } = harness(); const original = semanticWorldPacketFingerprint(packet);
const packet = getWorldPacket({ viewer, dataManager, styleManager });
const original = semanticWorldPacketFingerprint(packet);
const proseOnly = structuredClone(packet); const proseOnly = structuredClone(packet);
proseOnly.feedProvenance.note = 'different generated narration'; proseOnly.feedProvenance.note = 'different generated narration';
assert.equal(semanticWorldPacketFingerprint(proseOnly), original); assert.equal(semanticWorldPacketFingerprint(proseOnly), original);
const changed = structuredClone(packet); const changed = structuredClone(packet);
changed.layers[0].count += 1; changed.layers[0].count += 1;
assert.notEqual(semanticWorldPacketFingerprint(changed), original); assert.notEqual(semanticWorldPacketFingerprint(changed), original);
}, });
);
// The 2026-10 main voice contract omits disabled layers from the model payload. // The 2026-10 main voice contract omits disabled layers from the model payload.
test( test('World Packet and voice preserve enabled-only payload and count disabled layers', async () => {
'World Packet and voice preserve enabled-only payload and count disabled layers', const { viewer, dataManager, styleManager } = harness();
async () => { const rows = dataManager.getAll();
const { viewer, dataManager, styleManager } = harness(); rows.push({
const rows = dataManager.getAll(); id: 'earthquakes',
rows.push({ name: 'Earthquakes',
id: 'earthquakes', enabled: false,
name: 'Earthquakes', stats: { count: 99, source: 'fixture', error: 'stale' },
enabled: false, });
stats: { count: 99, source: 'fixture', error: 'stale' }, let reads = 0;
}); dataManager.getAll = () => {
let reads = 0; reads += 1;
dataManager.getAll = () => { return rows;
reads += 1; };
return rows; const packet = getWorldPacket({ viewer, dataManager, styleManager });
}; assert.equal(reads, 1, 'collect the roster once rather than repeatedly');
const packet = getWorldPacket({ viewer, dataManager, styleManager }); assert.equal(packet.disabledLayerCount, 1);
assert.equal(reads, 1, 'collect the roster once rather than repeatedly'); assert.deepEqual(
assert.equal(packet.disabledLayerCount, 1); packet.layers.map((layer) => layer.id),
assert.deepEqual(packet.layers.map((layer) => layer.id), ['traffic']); ['traffic'],
assert.equal(packet.feedProvenance.overall, 'nominal'); );
assert.equal(packet.feedProvenance.overall, 'nominal');
const runner = createGevActionRunner({ viewer, dataManager, styleManager }); const runner = createGevActionRunner({ viewer, dataManager, styleManager });
const voice = await runner('get_current_view_state'); const voice = await runner('get_current_view_state');
assert.deepEqual(voice, packet); assert.deepEqual(voice, packet);
}, });
);
test( test('World Packet fingerprints distinguish enabled state but ignore narrative churn', () => {
'World Packet fingerprints distinguish enabled state but ignore narrative churn', const { viewer, dataManager, styleManager } = harness();
() => { const first = getWorldPacket({ viewer, dataManager, styleManager });
const { viewer, dataManager, styleManager } = harness(); const prose = structuredClone(first);
const first = getWorldPacket({ viewer, dataManager, styleManager }); prose.feedProvenance.note = 'new narration only';
const prose = structuredClone(first); assert.equal(
prose.feedProvenance.note = 'new narration only'; semanticWorldPacketFingerprint(first),
assert.equal( semanticWorldPacketFingerprint(prose),
semanticWorldPacketFingerprint(first), );
semanticWorldPacketFingerprint(prose), const hidden = structuredClone(first);
); hidden.disabledLayerCount += 1;
const hidden = structuredClone(first); assert.notEqual(
hidden.disabledLayerCount += 1; semanticWorldPacketFingerprint(first),
assert.notEqual( semanticWorldPacketFingerprint(hidden),
semanticWorldPacketFingerprint(first), );
semanticWorldPacketFingerprint(hidden), });
);
},
);