benmichael/gods-eye-view
1
0 Fork 0
mirror of https://github.com/bilawalsidhu/gods-eye-view.git synced 2026-11-06 19:34:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update UI acceptance fixtures for panel ownership

Browse Source
This commit is contained in:
Sameh Khamis committed 2026-09-14 15:43:27 -07:00
1 parent dc81cf585c
commit e31e43f4b0
1 file changed
+11 -7
Download Patch File Download Diff File Expand all files Collapse all files
scripts/qa-map-source-tray.mjs
+11 -7
View File
@@ -1265,9 +1265,10 @@ try {
manager._setCommandDockPanelPinState(id, false, { persist: false, syncShare: false }); manager._setCommandDockPanelPinState(id, false, { persist: false, syncShare: false });
manager.setPanelCollapsed(id, true, { persist: false, syncShare: false }); manager.setPanelCollapsed(id, true, { persist: false, syncShare: false });
} }
const original = manager.setPanelCollapsed; const chrome = manager._panelChrome;
const probe = { transitions: [], restore: () => { manager.setPanelCollapsed = original; } }; const original = chrome.setPanelCollapsed;
manager.setPanelCollapsed = function (id, ...args) { const probe = { transitions: [], restore: () => { chrome.setPanelCollapsed = original; } };
chrome.setPanelCollapsed = function (id, ...args) {
const before = document.getElementById(id)?.classList.contains('collapsed'); const before = document.getElementById(id)?.classList.contains('collapsed');
const result = original.call(this, id, ...args); const result = original.call(this, id, ...args);
const after = document.getElementById(id)?.classList.contains('collapsed'); const after = document.getElementById(id)?.classList.contains('collapsed');
@@ -1474,7 +1475,8 @@ try {
getStats: () => ({ count: 1, lastUpdate: Date.now(), source: 'Local focus fixture' }), getStats: () => ({ count: 1, lastUpdate: Date.now(), source: 'Local focus fixture' }),
}); });
state.ids.push(transitionId); state.ids.push(transitionId);
manager._renderToggles(); const { application } = await import('/src/main.js');
application.getComponents().data.presentation.panel._renderToggles();
const offId = manager.getAll().find((layer) => !state.ids.includes(layer.id) && layer.showInTogglePanel && !layer.enabled)?.id; const offId = manager.getAll().find((layer) => !state.ids.includes(layer.id) && layer.showInTogglePanel && !layer.enabled)?.id;
return { return {
ready: Boolean(offId), offId, fixtureIds: state.ids.slice(0, 2), transitionId, ready: Boolean(offId), offId, fixtureIds: state.ids.slice(0, 2), transitionId,
@@ -1514,12 +1516,13 @@ try {
JSON.stringify({ setup: enabled ? 'dev QA fixture' : 'real production OFF row; not activated', navigation, state })); JSON.stringify({ setup: enabled ? 'dev QA fixture' : 'real production OFF row; not activated', navigation, state }));
await page.screenshot({ path: path.join(shotsDir, `${width}-data-${label.toLowerCase()}-focus.png`) }); await page.screenshot({ path: path.join(shotsDir, `${width}-data-${label.toLowerCase()}-focus.png`) });
if (label === 'OFF') { if (label === 'OFF') {
const passive = await page.evaluate((layerId) => { const passive = await page.evaluate(async (layerId) => {
const probe = window.__qaDataFocus; const probe = window.__qaDataFocus;
const focusBefore = document.activeElement; const focusBefore = document.activeElement;
const productionBefore = JSON.stringify(probe.production()); const productionBefore = JSON.stringify(probe.production());
const durableBefore = localStorage.getItem('gev:layer-state:v2'); const durableBefore = localStorage.getItem('gev:layer-state:v2');
window.__godsEyeView.dataManager._refreshTogglePanel(); const { application } = await import('/src/main.js');
application.getComponents().data.presentation.refresh();
return { return {
focusRetained: document.activeElement === focusBefore focusRetained: document.activeElement === focusBefore
&& focusBefore.matches('.data-toggle-btn') && focusBefore.matches('.data-toggle-btn')
@@ -1625,7 +1628,8 @@ try {
state.transition?.releaseDisable?.(); state.transition?.releaseDisable?.();
const removed = []; const removed = [];
for (const id of state.ids) removed.push(await window.__gevQaUnregisterLayer(manager, id)); for (const id of state.ids) removed.push(await window.__gevQaUnregisterLayer(manager, id));
manager._renderToggles(); const { application } = await import('/src/main.js');
application.getComponents().data.presentation.panel._renderToggles();
window.__godsEyeView.styleManager.setPanelCollapsed('data-panel', state.collapsed, { persist: false, syncShare: false }); window.__godsEyeView.styleManager.setPanelCollapsed('data-panel', state.collapsed, { persist: false, syncShare: false });
// A native user-origin toggle legitimately asks the production state // A native user-origin toggle legitimately asks the production state
// coordinator to persist. Restore the exact pre-fixture value so this // coordinator to persist. Restore the exact pre-fixture value so this