mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 16:52:20 +00:00
Drop the late feature changes of deleted Navara vector layers, which kept the view from going idle
This commit is contained in:
1 parent
843c4a111d
commit
e1d3a588fc
5 files changed
+85
-1
No files matched your search
@@ -6,6 +6,7 @@
|
||||
|
||||
import { ModelMesh } from '@navaramap/three';
|
||||
import { patchCascadedLightCopy } from './cascadedLightCopy.js';
|
||||
import { dropOrphanFeatureChanges } from './featureQueue.js';
|
||||
|
||||
export const NAVARA_INTERNALS_VERSION = '0.2.1';
|
||||
|
||||
@@ -156,11 +157,35 @@ export function keepCascadedLightIds(view) {
|
||||
: null;
|
||||
}
|
||||
|
||||
/**
|
||||
* The view's queued feature changes, for featureQueue.js, or null. Navara
|
||||
* keeps a change for a feature it does not know in that queue for good, so
|
||||
* a deleted layer's late changes keep the view from going idle. Private:
|
||||
* view._eventManager (stacks, removeAt). Upstream ask: drop a deleted
|
||||
* layer's pending feature events, or skip them in needsUpdate.
|
||||
*/
|
||||
export function featureChangeQueue(view) {
|
||||
const manager = view._eventManager;
|
||||
const events = manager?.stacks?.renderable_feature_changed;
|
||||
return events
|
||||
? {
|
||||
events,
|
||||
remove: (index) =>
|
||||
manager.removeAt('renderable_feature_changed', index),
|
||||
}
|
||||
: null;
|
||||
}
|
||||
|
||||
/** The hooks createNavaraEngine takes. */
|
||||
export const navaraHooks = (view) => ({
|
||||
retainTileGeometry,
|
||||
tileRoots: () => tileRoots(view),
|
||||
isIdle: () => isIdle(view),
|
||||
dropOrphanFeatureChanges: () =>
|
||||
dropOrphanFeatureChanges(
|
||||
featureChangeQueue(view),
|
||||
(id) => view.findLayerById(id) != null,
|
||||
),
|
||||
});
|
||||
|
||||
/**
|
||||
|
||||
Reference in new issue
Block a user