diff --git a/changelog.d/1864-kit-sweep-missions-radio.md b/changelog.d/1864-kit-sweep-missions-radio.md new file mode 100644 index 0000000000..9f2c26b390 --- /dev/null +++ b/changelog.d/1864-kit-sweep-missions-radio.md @@ -0,0 +1,2 @@ +- Space Missions', Contacts', Radio's, the RTL-SDR card's and key setup's + buttons and glyphs are now kit controls (manjunath22466, samehkhamis, #1864). diff --git a/docs/VUE-MIGRATION.md b/docs/VUE-MIGRATION.md index 7e8c323cd0..62d1c25b62 100644 --- a/docs/VUE-MIGRATION.md +++ b/docs/VUE-MIGRATION.md @@ -93,6 +93,13 @@ button, whose state the event layer writes into the attributes its panel renders, and Explore's story cards, which are `role="button"` elements, not buttons (`src/ui/kit/viewControls.test.mjs` pins it). Where the converted buttons draw Material symbols (the tilt-map button, the Context +header's search and expand, the imported files' row actions and the rail +chips' icons), the glyphs are `UiIcon`s with `:size="null"`, so the site +rules still size them. Core's pressable chips and pills (the rail cards' +chips and action chips, Recent Imagery's day chips, SWAP and ZOOM IN, map +sources, cities and places, the view context's place and layer chips and +the key setup chip) are `UiButton`s too. `UiChip` is a non-interactive +label chip, used by the voice card. header's search and expand, Draw, Import, the imported files' and drawn shapes' row actions and the rail chips' icons), the glyphs are `UiIcon`s with `:size="null"`, so the site rules still size them. Core's pressable @@ -193,6 +200,21 @@ while a query is typed. The Filter button opens a disclosure and carries a `UiIcon` with `:size="null"`, so `layer-finder.css` still sizes them (`src/ui/kit/layerFinderControls.test.mjs` pins it); the search field's magnifier is `UiSearchField`'s own span. +The Space Missions panel's buttons (a mission's roster row, FOCUS, +REPLAY ASCENT, the replay's pause, PREV, NEXT and SHOW ALL / DESELECT), +the Contacts panel's (PREV, FOCUS, NEXT and a contact's row), the Radio +panel's (Enable, PREV, PLAY, NEXT and STOP), the RTL-SDR card's (Connect, +Locate, Change device, FM, ADS-B, Tune and the two seeks) and the key +setup's (the POWER UP chip, a key's REMOVE, the voice auth toggle and +SAVE KEYS) are ghost `UiButton`s. Radio's Enable and the card's Connect, +FM and ADS-B are pressed toggles with `active`; PLAY and Locate keep +their own `active` class without `aria-pressed`, since their words say +what they will do or have done. The chip's bolt is a `UiIcon` with +`:size="null"`, so provider-settings.css still sizes it +(`src/ui/kit/missionsRadioControls.test.mjs` pins it). The card's FM +frequency stays a native number field, which the kit has no control for, +and the replay's pause, the roster's chevron and the compass arrows are +text characters, not Material symbols. Utilities' Draw and Import are on the kit. Draw (a pressed toggle with `active`), Clear and Import are ghost `UiButton`s, their glyphs `UiIcon`s with `pp-icon` and `:size="null"`. Draw's five colour swatches, in the diff --git a/scripts/format-scope.json b/scripts/format-scope.json index b35075cee6..2c71cede03 100644 --- a/scripts/format-scope.json +++ b/scripts/format-scope.json @@ -1355,6 +1355,7 @@ "src/ui/kit/cockpitControls.test.mjs", "src/ui/kit/smallSurfacesControls.test.mjs", "src/ui/kit/commandDockControls.test.mjs", + "src/ui/kit/missionsRadioControls.test.mjs", "src/ui/kit/drawControls.test.mjs", "src/ui/styles/chip.css", "src/ui/styles/empty-state.css", diff --git a/src/ui/kit/missionsRadioControls.test.mjs b/src/ui/kit/missionsRadioControls.test.mjs new file mode 100644 index 0000000000..5604a6517c --- /dev/null +++ b/src/ui/kit/missionsRadioControls.test.mjs @@ -0,0 +1,142 @@ +// The space missions, Contacts, Radio and provider settings controls are the +// kit's: none of their views hand-writes a + diff --git a/src/ui/views/panels/MissionRoster.vue b/src/ui/views/panels/MissionRoster.vue index 8c6a6aa130..39eaaae3ab 100644 --- a/src/ui/views/panels/MissionRoster.vue +++ b/src/ui/views/panels/MissionRoster.vue @@ -3,6 +3,7 @@ import { storeToRefs } from 'pinia'; import { onBeforeUpdate, onUpdated, ref } from 'vue'; import { t } from '../../../i18n/index.js'; import { useSpaceMissionsStore } from '../../stores/spaceMissions.js'; +import UiButton from '../../kit/UiButton.vue'; import UiEmpty from '../../kit/UiEmpty.vue'; // The Space Missions roster. The launches layer presents it; until it does, @@ -72,7 +73,7 @@ onUpdated(() => {
- + {{ entry.label }}{{ entry.provider }} · {{ entry.date }}

{{ t('TAB PREVIEWS · ENTER / SPACE SELECTS') }}

diff --git a/src/ui/views/panels/RadioPanel.vue b/src/ui/views/panels/RadioPanel.vue index 67a8f75439..6bd5e4e8ec 100644 --- a/src/ui/views/panels/RadioPanel.vue +++ b/src/ui/views/panels/RadioPanel.vue @@ -52,10 +52,10 @@ const radioWords = computed(() => ({
- - - - + {{ t('PREV') }} + {{ radio ? radio.transport.play.text : t('PLAY') }} + {{ t('NEXT') }} + {{ t('STOP') }}