mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-06 03:14:00 +00:00
fix(street-level): credit every imagery source in the attribution lightbox
Mapillary was never in DATA_CREDITS (since #768), and Google Street View, KartaView and Panoramax came without entries. HAL-530. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This commit is contained in:
1 parent
6390a3346f
commit
d983ef23d8
2 files changed
+29
No files matched your search
@@ -300,6 +300,22 @@ export const DATA_CREDITS = [
|
|||||||
'Traffic cameras (Toronto): contains information licensed under the ' +
|
'Traffic cameras (Toronto): contains information licensed under the ' +
|
||||||
'<a href="https://www.toronto.ca/city-government/data-research-maps/open-data/open-data-licence/" target="_blank" rel="noopener">Open Government Licence – Toronto</a>',
|
'<a href="https://www.toronto.ca/city-government/data-research-maps/open-data/open-data-licence/" target="_blank" rel="noopener">Open Government Licence – Toronto</a>',
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
key: 'mapillary',
|
||||||
|
html: 'Street Level: imagery © <a href="https://www.mapillary.com" target="_blank" rel="noopener">Mapillary</a> contributors, <a href="https://creativecommons.org/licenses/by-sa/4.0/" target="_blank" rel="noopener">CC BY-SA 4.0</a>',
|
||||||
|
},
|
||||||
|
{
|
||||||
|
key: 'google-street-view',
|
||||||
|
html: 'Street Level: Street View imagery © <a href="https://www.google.com/streetview/" target="_blank" rel="noopener">Google</a>',
|
||||||
|
},
|
||||||
|
{
|
||||||
|
key: 'kartaview',
|
||||||
|
html: 'Street Level: imagery © <a href="https://kartaview.org" target="_blank" rel="noopener">KartaView</a> contributors, <a href="https://creativecommons.org/licenses/by-sa/4.0/" target="_blank" rel="noopener">CC BY-SA 4.0</a>',
|
||||||
|
},
|
||||||
|
{
|
||||||
|
key: 'panoramax',
|
||||||
|
html: 'Street Level: imagery © <a href="https://panoramax.fr" target="_blank" rel="noopener">Panoramax</a> contributors, licence per picture',
|
||||||
|
},
|
||||||
{
|
{
|
||||||
key: 'gbfs',
|
key: 'gbfs',
|
||||||
html:
|
html:
|
||||||
|
|||||||
@@ -128,3 +128,16 @@ test('the NYC camera credit carries NYC DOT’s requested disclaimer', () => {
|
|||||||
assert.match(credit.html, /make no representation as to the accuracy/);
|
assert.match(credit.html, /make no representation as to the accuracy/);
|
||||||
assert.match(credit.html, /observe posted signage/);
|
assert.match(credit.html, /observe posted signage/);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('every Street Level imagery source is in the attribution lightbox', () => {
|
||||||
|
for (const key of [
|
||||||
|
'mapillary',
|
||||||
|
'google-street-view',
|
||||||
|
'kartaview',
|
||||||
|
'panoramax',
|
||||||
|
])
|
||||||
|
assert.ok(
|
||||||
|
DATA_CREDITS.some((entry) => entry.key === key),
|
||||||
|
`${key} has no credit`,
|
||||||
|
);
|
||||||
|
});
|
||||||
Reference in new issue
Block a user