mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-18 01:02:23 +00:00
Release the shell from a candidate engine that fails after it attached
The shell's scene part detaches it too, so a candidate failing in a later part (a layer's drawing, Cockpit clouds) leaves the shell free for the working engine instead of refusing every later attach. StyleManager.attachScene releases what it built when it throws, and one detach runs at a time. The controls phase awaits its parts, and a failed attachment no longer forces handoff off for the parts it releases. scripts/qa-app-once.mjs now also rolls back from a Navara candidate whose layer attachment fails.
This commit is contained in:
1 parent
58c8a481ed
commit
d86047fe8f
12 files changed
+229
-76
No files matched your search
@@ -306,7 +306,7 @@ test('newer navigation, reset, Cockpit, and teardown share one generation', () =
|
||||
'this._navigation.stop();',
|
||||
], 'dispose invalidation');
|
||||
// An engine switch retires the outgoing globe's navigation the same way.
|
||||
const detach = body(ui, /async detachScene\(\{[\s\S]*?\} = \{\}\) \{([\s\S]*?)\n \}/, 'detach');
|
||||
const detach = body(ui, /async _detachScene\(\{[\s\S]*?\} = \{\}\) \{([\s\S]*?)\n \}/, 'detach');
|
||||
ordered(detach, [
|
||||
'this._navigation.setScene(',
|
||||
'this._layerBindings.stop();',
|
||||
@@ -321,7 +321,7 @@ test('teardown synchronously closes immediate camera entry points', () => {
|
||||
'this._disposed = true;',
|
||||
'await this.detachScene(',
|
||||
], 'synchronous teardown barrier');
|
||||
const detach = body(ui, /async detachScene\(\{[\s\S]*?\} = \{\}\) \{([\s\S]*?)\n \}/, 'detach');
|
||||
const detach = body(ui, /async _detachScene\(\{[\s\S]*?\} = \{\}\) \{([\s\S]*?)\n \}/, 'detach');
|
||||
ordered(detach, [
|
||||
'this._layerBindings.stop();',
|
||||
'await this._contextControls.restoreForDisposal();',
|
||||
|
||||
Reference in new issue
Block a user