mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-19 01:32:19 +00:00
Fix the search bar's stale errors, hidden-field shortcuts and repeated Enter
From review: - An error goes when a chip is chosen, and a search's error shows only under the line it was for: a lookup that fails after the line was edited says nothing under the new text. - With voice on the field is hidden: "/" and Cmd/Ctrl+K no longer focus it, and nothing is looked up for it. - Without the action runner a refused or cancelled search keeps the line, as the plan path does (only true is success). - Text an input method is still composing is read when it is committed. - A held or repeated Enter does not restart the same line over its flight. - A city chip for the city whose landmarks are open flies there instead of folding the landmarks. - "villages around here" is looked up again for the current view. - Data Layers takes the full lane only where the desktop dock is laid out, by the condition omnibar-dock.css uses. - On short phones the HUD readout moves under the field it shared a row with. - CURRENT-STATE says the phone gains a field and which places are kept. Co-authored-by: Manjunath Paparaju <[email protected]>
This commit is contained in:
1 parent
24731951a0
commit
d7f10e4d2a
4 files changed
+70
-11
No files matched your search
+22
-1
@@ -7,6 +7,27 @@ import {
|
||||
import { measurePanelNaturalHeight } from './panelMeasurement.js';
|
||||
import { settleSideAccordion } from './panelAccordion.js';
|
||||
|
||||
/**
|
||||
* Whether the desktop Omnibar dock is laid out, by the condition
|
||||
* omnibar-dock.css lays it out by: the bar and the voice control in the
|
||||
* dock, outside the phone layout, the cockpit, playback, clean view and
|
||||
* recording.
|
||||
*/
|
||||
const DOCK_OFF = [
|
||||
'mobile-shell',
|
||||
'cockpit-mode',
|
||||
'scene-playback-mode',
|
||||
'ui-clean-view',
|
||||
'recording-mode',
|
||||
];
|
||||
function desktopOmnibarDock(documentRef) {
|
||||
if (!documentRef?.getElementById?.('gev-omnibar')) return false;
|
||||
const body = documentRef.body;
|
||||
if (DOCK_OFF.some((name) => body?.classList?.contains?.(name))) return false;
|
||||
const voice = documentRef.getElementById('gev-voice-control');
|
||||
return Boolean(voice) && voice.parentElement?.id === 'command-dock';
|
||||
}
|
||||
|
||||
/**
|
||||
* Measure and place the left panel rail for one synchronous layout pass.
|
||||
* The caller owns scheduling, obstacle selection, disclosure preferences and
|
||||
@@ -233,7 +254,7 @@ export function layoutLeftPanelRail({
|
||||
exclusive &&
|
||||
expandedPanels.length === 1 &&
|
||||
expandedPanels[0].id === 'data-panel' &&
|
||||
Boolean(documentRef?.getElementById?.('gev-omnibar'));
|
||||
desktopOmnibarDock(documentRef);
|
||||
const shouldTail =
|
||||
!fillDataLayers &&
|
||||
expandedPanels.length > 0 &&
|
||||
|
||||
Reference in new issue
Block a user