fix(globe): render holds and commanded on Navara

The render governor installs on a non-Cesium globe engine as its backend:
owner-counted holds drive engine.render.setContinuous and requests go to
engine.render.request, so orbit and every other per-frame owner keep
Navara drawing while held and let it idle once the last hold goes. Cesium
stays on the viewer path its engine delegates to.

A user gesture on Navara now ends a flight without raising
camera.commanded (the user is not a new camera owner). Headless Navara QA
checks both.
This commit is contained in:
German Khokhlov committed 2026-10-15 20:06:13 +04:00
1 parent c6e1b65c67
commit d112ecf296
5 files changed
+81 -5

No files matched your search

+26
View File
@@ -7,6 +7,8 @@ import {
governorRequestRender,
getRenderGovernorDiagnostics,
_resetRenderGovernorForTest,
isRenderGovernorInstalled,
uninstallRenderGovernor,
} from './renderGovernor.js';
function makeViewer() {
@@ -110,3 +112,27 @@ test('isRenderGovernorInstalled names the one governed viewer', async () => {
uninstallRenderGovernor(viewer);
assert.equal(isRenderGovernorInstalled(viewer), false);
});
test('on a non-Cesium globe engine the governor drives engine.render with owner-counted holds', async () => {
const { createFakeEngine } = await import('./globe/testing/fakeEngine.js');
_resetRenderGovernorForTest();
const engine = createFakeEngine({ kind: 'navara' });
holdContinuousRender('before-install');
installRenderGovernor(engine);
assert.equal(engine.render.isContinuous(), true, 'a hold taken before install applies');
releaseContinuousRender('before-install');
assert.equal(engine.render.isContinuous(), false);
holdContinuousRender('a');
holdContinuousRender('b');
assert.equal(engine.render.isContinuous(), true);
releaseContinuousRender('a');
assert.equal(engine.render.isContinuous(), true, 'b still holds');
releaseContinuousRender('b');
assert.equal(engine.render.isContinuous(), false);
engine.fake.resetCalls();
governorRequestRender('slider');
assert.deepEqual(engine.fake.callsOf('render.request').map((c) => c.args), [['slider']]);
assert.equal(isRenderGovernorInstalled(engine), true);
uninstallRenderGovernor(engine);
_resetRenderGovernorForTest();
});