mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
fix(voice): log a real send before bookkeeping; document decision reasons
Second review pass on #835's diagnostics. Behaviour is unchanged. - Report viewport_context.result as soon as the send returns, so a throw in the retained-frame bookkeeping cannot log a real send as "error". - List the decision reasons and when each field is present in CURRENT-STATE, note that the rate limit can split a pair, and say which codes are defensive. - Changelog: the decision is logged when an entity-context answer reaches the image step, not for every answer.
This commit is contained in:
1 parent
207eb9805d
commit
d0a612786a
4 files changed
+34
-11
No files matched your search
@@ -562,6 +562,12 @@ export class RealtimeViewport {
|
||||
// the item we just deleted as null and fall through so the caller still
|
||||
// issues queueResponseCreate WITHOUT the image, instead of stranding the turn.
|
||||
const sent = this.sendRealtimeEvent(contextEvent, label);
|
||||
// Report before the bookkeeping below, so a later throw cannot turn a
|
||||
// real send into a logged "error".
|
||||
report(
|
||||
'viewport_context.result',
|
||||
sent ? 'sent' : 'data-channel-send-failed',
|
||||
);
|
||||
this.lastViewportItemId = sent ? newItemId : null;
|
||||
this.retainedFrame = sent
|
||||
? {
|
||||
@@ -570,10 +576,6 @@ export class RealtimeViewport {
|
||||
cameraKey: this.readCameraKey(),
|
||||
}
|
||||
: null;
|
||||
report(
|
||||
'viewport_context.result',
|
||||
sent ? 'sent' : 'data-channel-send-failed',
|
||||
);
|
||||
return sent;
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user