mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-21 02:32:18 +00:00
Review of the PR's own code: joints, rings, node posing, card clearance
- A hand-set Canadarm2 joint no longer stops Dextre's and the Japanese arm's sway: only the joints set by hand hold still. - A ring already shown or hidden is not sent to the renderer again (the close-up asked for it every frame). - Node posing: the matrix handed to a node goes through one scratch (the node copies it), and a name the model lacks is looked up once. - The tracked card's clearance step holds until the clearance has left it, so jitter at a step's edge no longer republishes the card every frame. - A frame the station cannot be placed in gives its dots back rather than drawing neither model nor dot.
This commit is contained in:
1 parent
b1c5aa11b7
commit
ce3d292198
6 files changed
+36
-14
No files matched your search
@@ -633,7 +633,6 @@ export function createStationModel(
|
||||
if (
|
||||
!loading &&
|
||||
!failed &&
|
||||
resolveAsset &&
|
||||
dotPosition &&
|
||||
cameraDistance <= spec.maxDistanceM * 1.5
|
||||
)
|
||||
@@ -657,7 +656,10 @@ export function createStationModel(
|
||||
|
||||
const frame = _stationFrame(scratchPosition);
|
||||
if (!frame) {
|
||||
// Nowhere to draw the model (the orbit would not propagate): the dots
|
||||
// draw at every distance rather than nothing at all.
|
||||
_hide();
|
||||
_releaseDots();
|
||||
return;
|
||||
}
|
||||
const { date, axes } = frame;
|
||||
|
||||
Reference in new issue
Block a user