mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-19 17:52:21 +00:00
Read "from the map" after any switch or clear verb, before anything else
"clear everything except flights from the map" and "hide everything from the map" now read as they do without the ending, instead of only offering Ask GEV or a place search. Co-authored-by: Manjunath Paparaju <[email protected]>
This commit is contained in:
1 parent
81192cfa50
commit
cd5a4443a2
4 files changed
+27
-14
No files matched your search
@@ -292,6 +292,13 @@ export function normalizeLine(text, { isRequest = isPlainRequest } = {}) {
|
||||
/^((?:turn|switch) (?:on|off)|show|hide|remove|enable|disable|clear|go to|fly to)\s+\1\b/i,
|
||||
'$1',
|
||||
);
|
||||
// "remove flights from the map", "clear everything except ships from the
|
||||
// map": the map is where every layer is. Not the verb's own "off" ("turn
|
||||
// off the screen" is no layer switch).
|
||||
line = line.replace(
|
||||
/^((?:turn|switch) (?:on|off)|show|display|add|hide|remove|enable|disable|clear|toggle)\s+(\S.*?)\s+(?:from|off) (?:the )?(?:map|globe|screen|view)$/i,
|
||||
'$1 $2',
|
||||
);
|
||||
// "please" is dropped only around a request: "Please Touch Museum",
|
||||
// "Kindly Lane" and "Pretty Please" are names.
|
||||
const polite = line
|
||||
|
||||
@@ -1002,13 +1002,6 @@ export function createOmnibar({ layers = [], isEntity = () => false } = {}) {
|
||||
* ("Show Low, AZ").
|
||||
*/
|
||||
function switchRows(line, ask) {
|
||||
// "remove flights from the map": the map is where every layer is. Not
|
||||
// the verb's own "off" ("turn off the screen" is no layer switch).
|
||||
const bare = line.replace(
|
||||
/\s+(?:from|off) (?:the )?(?:map|globe|screen|view)$/i,
|
||||
'',
|
||||
);
|
||||
if (bare !== line && SWITCH.test(bare.toLowerCase())) line = bare;
|
||||
const excepted = exceptRows(line, ask);
|
||||
if (excepted) return excepted;
|
||||
const switching = line.toLowerCase().match(SWITCH);
|
||||
|
||||
@@ -805,12 +805,24 @@ test('"except" leaves Satellites to switch off with Space Missions off', () => {
|
||||
.rows[0].steps.map(stepOutcome),
|
||||
['layer(flights,off)', 'layer(satellites,off)'],
|
||||
);
|
||||
assert.deepEqual(
|
||||
omnibar
|
||||
.rows('hide everything except flights from the map', { places: [] })
|
||||
.rows[0].steps.map(stepOutcome),
|
||||
['layer(satellites,off)'],
|
||||
);
|
||||
for (const text of [
|
||||
'hide everything except flights from the map',
|
||||
'clear everything except flights from the map',
|
||||
])
|
||||
assert.deepEqual(
|
||||
omnibar.rows(text, { places: [] }).rows[0].steps.map(stepOutcome),
|
||||
['layer(satellites,off)'],
|
||||
text,
|
||||
);
|
||||
// The whole map cleared "from the map" is the same plan, not a place.
|
||||
for (const text of [
|
||||
'hide everything from the map',
|
||||
'remove all layers from the map',
|
||||
]) {
|
||||
const { rows } = omnibar.rows(text, { places: [] });
|
||||
assert.equal(rows[0].kind, 'plan', text);
|
||||
assert.ok(!rows.some((row) => row.kind === 'place'), text);
|
||||
}
|
||||
});
|
||||
|
||||
test('"turn off the screen" is no layer switch and no place', () => {
|
||||
|
||||
Reference in new issue
Block a user