mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
perf(navara): resolve MSAA at geometry stages
Keep four-sample geometry and depth while using single-sample postprocessing buffers. Preserve forward and overlay coverage, skip empty transfers, and add matched pixel and regression checks.
This commit is contained in:
1 parent
8279af2e6d
commit
c76872dfaa
6 files changed
+306
-1
No files matched your search
@@ -22,6 +22,7 @@ import { createNavaraSharpen } from './sharpen.js';
|
||||
import { createNavaraMovers } from './movers/index.js';
|
||||
import { createNavaraLines } from './lines/index.js';
|
||||
import { createNavaraOverlay } from './overlay.js';
|
||||
import { createPostSampling } from './postSampling.js';
|
||||
import {
|
||||
NAVARA_CONTEXT_ATTRIBUTES,
|
||||
ACES_FILMIC,
|
||||
@@ -108,6 +109,7 @@ export async function createNavaraGlobe({
|
||||
let engine;
|
||||
let overlay = null;
|
||||
let removeLook = null;
|
||||
let removePostSampling = null;
|
||||
try {
|
||||
view = new ThreeView(navaraViewOptions({ container, canvas, pixelRatio }));
|
||||
const plugin = new DefaultPlugin();
|
||||
@@ -127,6 +129,7 @@ export async function createNavaraGlobe({
|
||||
);
|
||||
// The look's shadowed sun leaked a light per frame (internals.js).
|
||||
keepCascadedLightIds(view);
|
||||
removePostSampling = createPostSampling(view);
|
||||
// Screen overlays and model display colour after tone mapping (overlay.js).
|
||||
overlay = createNavaraOverlay(view);
|
||||
engine = createNavaraEngine(view, {
|
||||
@@ -182,6 +185,7 @@ export async function createNavaraGlobe({
|
||||
removeLook = () => removers.forEach((remove) => remove());
|
||||
} catch (error) {
|
||||
removeLook?.();
|
||||
removePostSampling?.();
|
||||
engine?.destroy();
|
||||
overlay?.destroy();
|
||||
view?.dispose();
|
||||
@@ -201,6 +205,7 @@ export async function createNavaraGlobe({
|
||||
if (destroyed) return;
|
||||
destroyed = true;
|
||||
removeLook();
|
||||
removePostSampling();
|
||||
engine.destroy();
|
||||
overlay.destroy();
|
||||
view.dispose();
|
||||
|
||||
Reference in new issue
Block a user