mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-20 02:02:21 +00:00
fix(ui): right rail tabs: review fixes, launcher in the strip, strip never scrolls on common windows
Review fixes P1.1-P2.7: a panel hidden at mount gets its tab when revealed; any live opening of a rail panel makes it the owner, restores do not; a short lane scrolls the strip with a thin scrollbar and brings a newly opened tab into view once; the join and the panel cover stay inside the lane and the fillet shrinks to the room left; a share link carries an owner-collapsed peer as collapsed so the recipient opens the sender's panel; border-box on phones; the strip's column folds into the panel width at 721-760px; the focus ring draws inside the tab. The compact Radio launcher moves from Context's header into a tool slot under the tabs on desktop (back into the header for the phone sheet) and always toggles the compact player, also while Context is open; the player's Details button leads to the Radio section. The jump-to-section role, its two labels and the #804 closings of the player on Context expansion and rail layout passes are gone with it. The rail panels' own collapse arrows are hidden on desktop: the tab opens and closes a panel, Escape inside closes it and returns focus to the tab. The tabs are denser and the rail climbs toward the HUD corner above its left-rail baseline when the strip's column is taller than the lane, so the strip no longer scrolls on windows down to about 680px tall; the measuring pass keeps the strip's scroll offset. scripts/qa-radio.mjs expectations follow the launcher's new role. Co-Authored-By: Claude Fable 5.1 <[email protected]>
This commit is contained in:
1 parent
ff017c99ca
commit
bff1d0eb29
24 files changed
+804
-379
No files matched your search
@@ -375,6 +375,35 @@ test('right rail aligns to the current left rail and excludes hidden obstacles',
|
||||
assert.equal(f.stack.dataset.safeTop, '200.0');
|
||||
});
|
||||
|
||||
test('right rail climbs above the left rail baseline when its tab strip needs the room, no further than the HUD above', () => {
|
||||
const f = fixture('right');
|
||||
f.options.leftStack.rect.top = 300;
|
||||
const above = element('above', { left: 1100, top: 100, height: 50 });
|
||||
const below = element('below', { left: 1100, top: 600, height: 50 });
|
||||
f.options.obstacles = [above, below];
|
||||
const column = element('column', { height: 380 });
|
||||
f.stack.querySelector = (selector) =>
|
||||
selector.includes('#right-rail-column') ? column : null;
|
||||
// The gap is 10.8 at 900px: the lane 300..589.2 is 90.8 short of the column.
|
||||
f.run();
|
||||
assert.equal(f.stack.dataset.safeTop, '209.2');
|
||||
assert.equal(f.stack.dataset.safeBottom, '589.2');
|
||||
column.rect.height = 600;
|
||||
f.run();
|
||||
assert.equal(
|
||||
f.stack.dataset.safeTop,
|
||||
'160.8',
|
||||
'the HUD corner above stops the climb',
|
||||
);
|
||||
column.rect.height = 200;
|
||||
f.run();
|
||||
assert.equal(
|
||||
f.stack.dataset.safeTop,
|
||||
'300.0',
|
||||
'a column that fits leaves the baseline alone',
|
||||
);
|
||||
});
|
||||
|
||||
// The left rail's `top` animates after the right pass runs, and nothing
|
||||
// re-runs it when the transition lands: the right rail must read the end value.
|
||||
function animatingLeftRail({ keyframes = true } = {}) {
|
||||
|
||||
Reference in new issue
Block a user