From be9d772b4d53f141656936528cc6f7395d93512d Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Thu, 19 Nov 2026 02:29:52 -0800 Subject: [PATCH] Vue kit: the Omnibar's mic and strip chips are UiButtons and its glyphs UiIcons The mic is a ghost UiButton pressed with the active class, and the suggestion strip's chips are ghost UiButtons that keep their option role and aria-current. The search, row and chip glyphs are UiIcons sized by the Omnibar's own rules. The mic and chat row glyphs stay inline SVG, since no loaded Material symbol draws them. A guard test pins it. Co-authored-by: Manjunath Paparaju --- docs/VUE-MIGRATION.md | 8 +++++++ scripts/format-scope.json | 1 + src/ui/kit/omnibarControls.test.mjs | 34 +++++++++++++++++++++++++++++ src/ui/views/panels/Omnibar.vue | 17 ++++++++------- 4 files changed, 52 insertions(+), 8 deletions(-) create mode 100644 src/ui/kit/omnibarControls.test.mjs diff --git a/docs/VUE-MIGRATION.md b/docs/VUE-MIGRATION.md index b7c030dc10..e67cf663b1 100644 --- a/docs/VUE-MIGRATION.md +++ b/docs/VUE-MIGRATION.md @@ -89,6 +89,14 @@ tilt-map button, whose owners still write their state into the DOM. Core's pressable chips and pills (rail card chips, map sources, cities and places) are `UiButton`s too; `UiChip` is a non-interactive label chip, used by the voice card. +The Omnibar's mic (a pressed toggle with `active`) and its suggestion +strip's chips (options, so `aria-current` rather than `pressed`) are +ghost `UiButton`s, and its search, row and chip glyphs are `UiIcon`s with +`:size="null"`, so its own rules still size them +(`src/ui/kit/omnibarControls.test.mjs` pins it). The mic's and the chat +row's glyphs stay inline SVG, since no Material symbol the page loads +draws them, and its field is its own combobox rather than a +`UiSearchField`. `UiSelect` renders the bare native select (Core's labels sit outside it or come as an `aria-label`) with `v-model`, `options` and `disabled`; options that carry their own attributes come through the slot, a caller's diff --git a/scripts/format-scope.json b/scripts/format-scope.json index 76004da995..d473ffd33f 100644 --- a/scripts/format-scope.json +++ b/scripts/format-scope.json @@ -1343,6 +1343,7 @@ "src/ui/kit/UiDialog.vue", "src/ui/kit/UiDialog.test.mjs", "src/ui/kit/dialogs.test.mjs", + "src/ui/kit/omnibarControls.test.mjs", "src/ui/styles/chip.css", "src/ui/styles/empty-state.css", "src/ui/rail/RailChips.vue", diff --git a/src/ui/kit/omnibarControls.test.mjs b/src/ui/kit/omnibarControls.test.mjs new file mode 100644 index 0000000000..033412d0a0 --- /dev/null +++ b/src/ui/kit/omnibarControls.test.mjs @@ -0,0 +1,34 @@ +// The Omnibar's buttons and Material glyphs are the kit's: its template +// hand-writes no +
@@ -1065,11 +1067,10 @@ watch(
  • - + {{ item.label }} {{ item.hint }}