mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-21 02:32:18 +00:00
fix(click): the card or label on top takes the click in every layer
Review fixes for #1781: - One rule for cards: the world-overlay host hands its hit test to the pick registry, and every click handler reads the topmost interactive card or label once per click (`clickCard`, `isUnderOtherCard` in src/data/pickRegistry.js), so all handlers agree in any listener order. A layer whose own card or label is on top acts on it whatever is drawn under it; a layer under another layer's card neither acts nor treats the click as empty space (a tracked aircraft stays tracked, a selection stays selected); Context names nothing under a card. A selected news card over a vessel no longer opens the link and selects the vessel. - With one rule, the per-owner arbitration options are no longer read and are removed: `passive`, `expanded` and `declinesClick` pick owners, `rememberClickPickActions`, `isActedOnByOtherLayer`, card backgrounds and `cardKeepsClick`. The dispatcher is unchanged from main. - A drag that ends on a quake disc, label or card does nothing; opening the USGS page or clearing the selection needs a clean click. - A click on the map under another layer's card opens no Street Level ground image. - A CCTV card that is going away is still not the scene under it. - Docs and changelog describe the new rule.
This commit is contained in:
1 parent
7312280817
commit
bb3bf9858b
87 files changed
+1398
-1775
No files matched your search
@@ -28,8 +28,8 @@ test('a card painted over a launch marker keeps its click; with none the mission
|
||||
state,
|
||||
services: {
|
||||
render: { holdContinuousRender() {}, releaseContinuousRender() {} },
|
||||
overlays: { hitTestWorldOverlay: () => top },
|
||||
picking,
|
||||
// The card on top at a click, as the registry answers from the host.
|
||||
picking: { ...picking, clickCard: () => top },
|
||||
},
|
||||
parts: {
|
||||
panel: stubs(),
|
||||
@@ -61,15 +61,6 @@ test('a card painted over a launch marker keeps its click; with none the mission
|
||||
['L1'],
|
||||
'with no card on top, the mission selects',
|
||||
);
|
||||
// So a card on top (a live CCTV card) may act over the mission instead.
|
||||
const mission = { set: 'launches:1:markers', id: 'mission:L1' };
|
||||
assert.equal(picking.isCardBackground(mission), true);
|
||||
assert.equal(picking.isCardBackground({ ...mission, id: 'x' }), false);
|
||||
state._enabled = false;
|
||||
assert.equal(picking.isCardBackground(mission), false);
|
||||
state._inputSubscription();
|
||||
state._enabled = true;
|
||||
assert.equal(picking.isCardBackground(mission), false);
|
||||
} finally {
|
||||
state._inputSubscription?.();
|
||||
input.destroy();
|
||||
|
||||
Reference in new issue
Block a user