mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-17 00:32:21 +00:00
Stories: reach the globe through the renderer's ports
Main now keeps Cesium behind the renderer contract, so Stories stops reaching Cesium and the viewer directly. - Camera: flights, the -60 degree story framing, cancel, the pose saved on open and put back on Close go through the camera port; a follow is released with stopFollowing. - Pins: placed in the frame port's postRender from the query port's projection and horizon test, still written straight to each pin's transform on every drawn frame. - Tile settling: a continuous-render hold until the globe port reports the base settled, for at most 10 s. - Clock: Close and Back to Explore put back the page's world clock (live, or the time it showed, playing on), and leave a clock that is still where it should be alone. - Card images: drawn from Esri World Imagery's own Web Mercator tiles while the Esri map stack is active, read as images; no Cesium imagery provider is touched. - THUMBNAIL: the director hands captureStoryThumb the frame port and the renderer's canvas, so the scene document's module stays renderer-free. - Credits: Stories places and keeps visible the application's credit line (#gev-credits) and its list as well as the renderer's own display. - Tests fake the ports instead of a Cesium viewer, and cover pins per frame, the flights, the settling bound and the clock restore; the share link tests Stories added build their manager over a camera port.
This commit is contained in:
1 parent
9e9ce1db22
commit
b8e622aac8
15 files changed
+695
-376
No files matched your search
@@ -12,13 +12,23 @@ const view = readFileSync(
|
||||
'utf8',
|
||||
);
|
||||
|
||||
/** Every declaration block in stories.css whose selector names the credit line. */
|
||||
/**
|
||||
* Every declaration block in stories.css whose selector names the credit
|
||||
* line: the renderer's own display (`#cesium-credits`) or the application's
|
||||
* line (`#gev-credits`, src/ui/creditsView.js), with its selectors one each.
|
||||
*/
|
||||
function creditBlocks() {
|
||||
const blocks = [];
|
||||
const re = /([^{}]+)\{([^{}]*)\}/g;
|
||||
for (let m; (m = re.exec(css));) {
|
||||
if (m[1].includes('#cesium-credits'))
|
||||
blocks.push({ selector: m[1].trim(), body: m[2] });
|
||||
if (/#(cesium|gev)-credits/.test(m[1]))
|
||||
blocks.push({
|
||||
selector: m[1].trim(),
|
||||
selectors: m[1]
|
||||
.split(/,(?![^(]*\))/)
|
||||
.map((part) => part.replace(/\s+/g, ' ').trim()),
|
||||
body: m[2],
|
||||
});
|
||||
}
|
||||
return blocks;
|
||||
}
|
||||
@@ -33,21 +43,24 @@ test('Stories never hides GEV’s required credit line', () => {
|
||||
selector,
|
||||
);
|
||||
}
|
||||
// The rule that hides GEV's chrome while Stories is open exempts the credit.
|
||||
assert.match(
|
||||
css,
|
||||
/body\.stories-mode\s*>\s*:not\([^)]*\[id='cesium-credits'\]/,
|
||||
);
|
||||
// The rule that hides GEV's chrome while Stories is open exempts the
|
||||
// credit, whichever display shows it, and the application's credit list.
|
||||
for (const id of ['cesium-credits', 'gev-credits', 'gev-credits-panel'])
|
||||
assert.match(
|
||||
css,
|
||||
new RegExp(`body\\.stories-mode\\s*>\\s*:not\\([^)]*\\[id='${id}'\\]`),
|
||||
id,
|
||||
);
|
||||
});
|
||||
|
||||
test('a playing scene’s recording mode cannot move the credit under the timeline', () => {
|
||||
const placement = creditBlocks().find(
|
||||
({ selector, body }) =>
|
||||
/^body\.stories-mode:not\(#gs-a\):not\(#gs-b\)\s+#cesium-credits$/.test(
|
||||
selector,
|
||||
({ selectors, body }) =>
|
||||
['cesium-credits', 'gev-credits'].every((id) =>
|
||||
selectors.includes(`body.stories-mode:not(#gs-a):not(#gs-b) #${id}`),
|
||||
) && /bottom\s*:/.test(body),
|
||||
);
|
||||
assert.ok(placement, 'Stories pins the credit line');
|
||||
assert.ok(placement, 'Stories pins the credit line, either display');
|
||||
// Two ids outrank body.recording-mode #cesium-credits and the phone shell's
|
||||
// !important rule (one id each), so the measured place holds while playing.
|
||||
assert.match(
|
||||
|
||||
Reference in new issue
Block a user