mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-19 09:42:21 +00:00
Stories: reach the globe through the renderer's ports
Main now keeps Cesium behind the renderer contract, so Stories stops reaching Cesium and the viewer directly. - Camera: flights, the -60 degree story framing, cancel, the pose saved on open and put back on Close go through the camera port; a follow is released with stopFollowing. - Pins: placed in the frame port's postRender from the query port's projection and horizon test, still written straight to each pin's transform on every drawn frame. - Tile settling: a continuous-render hold until the globe port reports the base settled, for at most 10 s. - Clock: Close and Back to Explore put back the page's world clock (live, or the time it showed, playing on), and leave a clock that is still where it should be alone. - Card images: drawn from Esri World Imagery's own Web Mercator tiles while the Esri map stack is active, read as images; no Cesium imagery provider is touched. - THUMBNAIL: the director hands captureStoryThumb the frame port and the renderer's canvas, so the scene document's module stays renderer-free. - Credits: Stories places and keeps visible the application's credit line (#gev-credits) and its list as well as the renderer's own display. - Tests fake the ports instead of a Cesium viewer, and cover pins per frame, the flights, the settling bound and the clock restore; the share link tests Stories added build their manager over a camera port.
This commit is contained in:
1 parent
9e9ce1db22
commit
b8e622aac8
15 files changed
+695
-376
No files matched your search
@@ -100,48 +100,55 @@ test('encodeStoryThumb lowers the quality until the image fits, then gives up',
|
||||
);
|
||||
});
|
||||
|
||||
/** A Cesium scene double: postRender listeners run on requestRender. */
|
||||
function fakeViewer({ draws = true } = {}) {
|
||||
/**
|
||||
* The renderer's frame port double, running postRender listeners on
|
||||
* requestRender, and the canvas it draws in.
|
||||
*/
|
||||
function fakeGlobe({ draws = true } = {}) {
|
||||
const listeners = new Set();
|
||||
const scene = {
|
||||
canvas: { width: 640, height: 360 },
|
||||
const frame = {
|
||||
renders: 0,
|
||||
postRender: {
|
||||
addEventListener(listener) {
|
||||
listeners.add(listener);
|
||||
return () => listeners.delete(listener);
|
||||
},
|
||||
reasons: [],
|
||||
on(phase, listener) {
|
||||
assert.equal(phase, 'postRender');
|
||||
listeners.add(listener);
|
||||
return () => listeners.delete(listener);
|
||||
},
|
||||
requestRender() {
|
||||
scene.renders++;
|
||||
if (draws) for (const listener of [...listeners]) listener();
|
||||
requestRender(reason) {
|
||||
frame.renders++;
|
||||
frame.reasons.push(reason);
|
||||
if (draws) for (const listener of [...listeners]) listener({});
|
||||
},
|
||||
listeners,
|
||||
};
|
||||
return { scene };
|
||||
return { globe: { frame, canvas: { width: 640, height: 360 } }, frame };
|
||||
}
|
||||
|
||||
test('captureStoryThumb reads the canvas inside the postRender it requested', async () => {
|
||||
const viewer = fakeViewer();
|
||||
const { globe, frame } = fakeGlobe();
|
||||
const { create } = fakeCanvases();
|
||||
const url = await captureStoryThumb(viewer, { createCanvas: create });
|
||||
const url = await captureStoryThumb(globe, { createCanvas: create });
|
||||
assert.equal(url, 'data:image/jpeg;base64,AAAA');
|
||||
assert.equal(viewer.scene.renders, 1);
|
||||
assert.equal(viewer.scene.listeners.size, 0, 'the listener is removed');
|
||||
assert.equal(frame.renders, 1);
|
||||
assert.deepEqual(frame.reasons, ['story-thumb']);
|
||||
assert.equal(frame.listeners.size, 0, 'the listener is removed');
|
||||
});
|
||||
|
||||
test('captureStoryThumb gives up when no frame is drawn or there is no globe', async () => {
|
||||
const viewer = fakeViewer({ draws: false });
|
||||
const { globe, frame } = fakeGlobe({ draws: false });
|
||||
await assert.rejects(
|
||||
captureStoryThumb(viewer, {
|
||||
captureStoryThumb(globe, {
|
||||
createCanvas: fakeCanvases().create,
|
||||
timeoutMs: 1,
|
||||
}),
|
||||
/No frame was drawn/,
|
||||
);
|
||||
assert.equal(viewer.scene.listeners.size, 0);
|
||||
assert.equal(frame.listeners.size, 0);
|
||||
await assert.rejects(
|
||||
captureStoryThumb({}, { createCanvas: fakeCanvases().create }),
|
||||
captureStoryThumb(
|
||||
{ frame: null, canvas: null },
|
||||
{ createCanvas: fakeCanvases().create },
|
||||
),
|
||||
/Globe not ready/,
|
||||
);
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user