mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-19 01:32:19 +00:00
fix(input): no double-click follow or zoom on the map
The globe viewer's own double-click tracked a picked entity with a position or zoomed to one without. Layers moving onto the draw port had it re-created one by one (data/stockFollow.js); following is a click in GEV, so the viewer's handler is removed where the viewer is made and every re-creation goes: earthquakes, cyclones, air quality, news, perimeters, drone airspace, ghost maps, places, radio, cables, CCTV, ALPR, launches, bikeshare, Local ADS-B, installations, directions, trails, data packs, annotations, the library's view and local GeoJSON. The Cockpit's own double-click and the draw tool's finishing double-click stay.
This commit is contained in:
1 parent
bb2d22dbce
commit
b86014244d
69 files changed
+94
-2797
No files matched your search
+12
-81
@@ -18,10 +18,8 @@ import {
|
||||
drawOf,
|
||||
findCamera,
|
||||
findGlobe,
|
||||
findInput,
|
||||
findQuery,
|
||||
} from '../render/rendererOf.js';
|
||||
import { drawnItemTarget, followOnDoubleClick } from '../data/stockFollow.js';
|
||||
import { cssColor } from '../render/color.js';
|
||||
import { markBaseTileset } from '../render/baseTilesets.js';
|
||||
import { fromDegrees, toLonLatH } from '../geo/ellipsoid.js';
|
||||
@@ -90,28 +88,6 @@ function libraryRowControls(getExtent, onZoom, onRemove, legend = []) {
|
||||
* given; otherwise the manifest's static `display.legend` (a tile layer's
|
||||
* colour scale). Labels travel with the colours, so colour is never alone.
|
||||
*/
|
||||
/**
|
||||
* A double-click on one of a library layer's drawn items follows it (a
|
||||
* point) or zooms to it (a line or area), as the default renderer did for
|
||||
* the entities they were; null on a scene that takes no input.
|
||||
* @param {object} viewer
|
||||
* @param {string} name The layer, for warnings.
|
||||
* @param {() => boolean} enabled
|
||||
* @param {(hit: {set: string, id: string}) => object|null|undefined} itemFor
|
||||
* The item a hit names, if it is the layer's.
|
||||
*/
|
||||
function libraryDoubleClick(viewer, name, enabled, itemFor) {
|
||||
const input = viewer ? findInput(viewer) : null;
|
||||
if (!input) return null;
|
||||
return followOnDoubleClick({
|
||||
viewer,
|
||||
inputFor: () => input,
|
||||
name,
|
||||
enabled,
|
||||
targetFor: (hit) => drawnItemTarget(hit.set, itemFor(hit)),
|
||||
});
|
||||
}
|
||||
|
||||
export function colorByLegend(display, counts = null) {
|
||||
const colorBy = display?.colorBy;
|
||||
if (!colorBy)
|
||||
@@ -495,13 +471,9 @@ export function createLibraryTileLayer(
|
||||
let outlineCount = 0;
|
||||
let outlineEpoch = 0;
|
||||
let outlineBuilds = 0;
|
||||
/** The outline's rings by item id, for a double-click to zoom to. */
|
||||
let outlineItems = new Map();
|
||||
let outlineZoom = null;
|
||||
|
||||
function removeOutline() {
|
||||
outlineEpoch += 1;
|
||||
outlineItems = new Map();
|
||||
try {
|
||||
outline?.dispose();
|
||||
} catch {
|
||||
@@ -526,27 +498,27 @@ export function createLibraryTileLayer(
|
||||
);
|
||||
if (epoch !== outlineEpoch || !enabled || !rings.length) return;
|
||||
const color = cssColor(OUTLINE_COLOR);
|
||||
// Pickable, as the polyline entities were: a double-click on a
|
||||
// border zooms to it.
|
||||
const set = drawOf(viewer).lines({
|
||||
id: `${id}:outline:${++outlineBuilds}`,
|
||||
pickable: false,
|
||||
});
|
||||
const items = rings.map((ring, index) => ({
|
||||
id: String(index),
|
||||
positions: ring.map(([lon, lat]) => fromDegrees(lon, lat, 0)),
|
||||
widthPx: OUTLINE_WIDTH_PX,
|
||||
mode: 'draped',
|
||||
clampTo: 'both',
|
||||
style: { kind: 'solid', color },
|
||||
}));
|
||||
try {
|
||||
set.set(items);
|
||||
set.set(
|
||||
rings.map((ring, index) => ({
|
||||
id: String(index),
|
||||
positions: ring.map(([lon, lat]) => fromDegrees(lon, lat, 0)),
|
||||
widthPx: OUTLINE_WIDTH_PX,
|
||||
mode: 'draped',
|
||||
clampTo: 'both',
|
||||
style: { kind: 'solid', color },
|
||||
pickable: false,
|
||||
})),
|
||||
);
|
||||
} catch (error) {
|
||||
set.dispose();
|
||||
throw error;
|
||||
}
|
||||
outline = set;
|
||||
outlineItems = new Map(items.map((item) => [item.id, item]));
|
||||
outlineCount = rings.length;
|
||||
if (outlineMode !== 'bbox')
|
||||
registerDynamicCredit(viewer, NATURAL_EARTH_CREDIT);
|
||||
@@ -640,13 +612,6 @@ export function createLibraryTileLayer(
|
||||
const off = mapStackController?.subscribe?.(followMap);
|
||||
unsubscribeMap = typeof off === 'function' ? off : null;
|
||||
void drawOutline();
|
||||
if (outlineMode && !outlineZoom)
|
||||
outlineZoom = libraryDoubleClick(
|
||||
viewer,
|
||||
id,
|
||||
() => enabled,
|
||||
(hit) => (hit.set === outline?.id ? outlineItems.get(hit.id) : null),
|
||||
);
|
||||
requestRender(`library-tiles:${entry.id}`);
|
||||
},
|
||||
async disable() {
|
||||
@@ -655,8 +620,6 @@ export function createLibraryTileLayer(
|
||||
unsubscribeMap = null;
|
||||
detach();
|
||||
removeOutline();
|
||||
outlineZoom?.destroy();
|
||||
outlineZoom = null;
|
||||
requestRender(`library-tiles:${entry.id}`);
|
||||
},
|
||||
async destroy() {
|
||||
@@ -665,8 +628,6 @@ export function createLibraryTileLayer(
|
||||
unsubscribeMap = null;
|
||||
detach();
|
||||
removeOutline();
|
||||
outlineZoom?.destroy();
|
||||
outlineZoom = null;
|
||||
viewer = null;
|
||||
},
|
||||
getStats() {
|
||||
@@ -753,9 +714,6 @@ export function createLibraryViewLayer(
|
||||
let enabled = false;
|
||||
/** The sets drawing the current view's features, or null. */
|
||||
let drawn = null;
|
||||
/** Each build's items by set id, then item id, for a double-click. */
|
||||
const itemsOf = new WeakMap();
|
||||
let stockFollow = null;
|
||||
let builds = 0;
|
||||
let controller = null;
|
||||
let timer = null;
|
||||
@@ -786,8 +744,6 @@ export function createLibraryViewLayer(
|
||||
}
|
||||
|
||||
function clear() {
|
||||
// Removing the entities ended the default renderer's follow of one.
|
||||
stockFollow?.stop();
|
||||
disposeSets(drawn);
|
||||
drawn = null;
|
||||
loadedKey = null;
|
||||
@@ -859,19 +815,6 @@ export function createLibraryViewLayer(
|
||||
sets.fills.set(fills);
|
||||
sets.lines.set(lines);
|
||||
sets.dots.set(dots);
|
||||
itemsOf.set(
|
||||
sets,
|
||||
new Map(
|
||||
[
|
||||
[sets.fills.id, fills],
|
||||
[sets.lines.id, lines],
|
||||
[sets.dots.id, dots],
|
||||
].map(([setId, list]) => [
|
||||
setId,
|
||||
new Map(list.map((item) => [item.id, item])),
|
||||
]),
|
||||
),
|
||||
);
|
||||
} catch (caught) {
|
||||
disposeSets(sets);
|
||||
throw caught;
|
||||
@@ -964,8 +907,6 @@ export function createLibraryViewLayer(
|
||||
const previous = drawn;
|
||||
drawn = sets;
|
||||
for (const set of Object.values(sets)) set.show = true;
|
||||
// Replacing the entities ended the default renderer's follow of one.
|
||||
if (previous) stockFollow?.stop();
|
||||
disposeSets(previous);
|
||||
count = result.features.length;
|
||||
truncated = result.truncated;
|
||||
@@ -1017,28 +958,18 @@ export function createLibraryViewLayer(
|
||||
registerDynamicCredit(viewer, libraryCredit(entry));
|
||||
removeMoveEnd?.();
|
||||
removeMoveEnd = findCamera(viewer)?.on('moveEnd', schedule) ?? null;
|
||||
stockFollow ??= libraryDoubleClick(
|
||||
viewer,
|
||||
id,
|
||||
() => enabled,
|
||||
(hit) => (drawn ? itemsOf.get(drawn)?.get(hit.set)?.get(hit.id) : null),
|
||||
);
|
||||
await refresh();
|
||||
},
|
||||
async disable() {
|
||||
enabled = false;
|
||||
stop();
|
||||
clear();
|
||||
stockFollow?.destroy();
|
||||
stockFollow = null;
|
||||
render();
|
||||
},
|
||||
async destroy() {
|
||||
enabled = false;
|
||||
stop();
|
||||
clear();
|
||||
stockFollow?.destroy();
|
||||
stockFollow = null;
|
||||
viewer = null;
|
||||
},
|
||||
getStats() {
|
||||
|
||||
Reference in new issue
Block a user