fix(input): no double-click follow or zoom on the map

The globe viewer's own double-click tracked a picked entity with a
position or zoomed to one without. Layers moving onto the draw port had it
re-created one by one (data/stockFollow.js); following is a click in GEV,
so the viewer's handler is removed where the viewer is made and every
re-creation goes: earthquakes, cyclones, air quality, news, perimeters,
drone airspace, ghost maps, places, radio, cables, CCTV, ALPR, launches,
bikeshare, Local ADS-B, installations, directions, trails, data packs,
annotations, the library's view and local GeoJSON. The Cockpit's own
double-click and the draw tool's finishing double-click stay.
This commit is contained in:
Sameh Khamis committed 2026-11-14 09:10:14 -08:00
1 parent bb2d22dbce
commit b86014244d
69 files changed
+94 -2797

No files matched your search

-28
View File
@@ -13,7 +13,6 @@ import {
findQuery,
} from '../../render/rendererOf.js';
import { inputFor } from '../../input/dispatcher.js';
import { followOnDoubleClick } from '../../data/stockFollow.js';
import { pickRenderAltitudeM } from '../../data/renderAltitude.js';
import { routePlausible } from '../../data/routePlausible.js';
import {
@@ -151,8 +150,6 @@ export function createLocalAdsbLayer({
let tickTimer = null;
let syncTimer = null;
let clickSubscription = null;
/** The follow a double-click on a marker started, while installed. */
let stockFollow = null;
let removePreRender = null;
let renderHeld = false;
let selectedId = null;
@@ -571,9 +568,6 @@ export function createLocalAdsbLayer({
if (ringsGone.length) sets.rings.remove(ringsGone);
// Expired aircraft take their 3D models (and pending loads) with them.
if (removed) models?.retain(markers);
// An aircraft that went took the follow a double-click gave it.
const followed = stockFollow?.following;
if (followed && !markers.has(followed.key)) stockFollow.stop();
if (selectedId && !live.has(selectedId))
clearSelection({ evicted: enabled });
removeEntityContextsForLayer(LAYER_ID, { retainIds: live });
@@ -688,26 +682,6 @@ export function createLocalAdsbLayer({
function installInteraction() {
if (clickSubscription || !viewer) return;
// A double-click follows a local aircraft, its card shown, as the
// default renderer followed its entity.
stockFollow = followOnDoubleClick({
viewer,
inputFor,
name: LAYER_ID,
enabled: () => enabled,
targetFor: (hit) => {
const marker =
!hit.surface &&
(hit.set === sets?.markers.id || hit.set === sets?.rings.id) &&
markers.get(hit.id);
if (!marker?.carrier) return null;
return {
key: marker.id,
position: () => (marker.position ? { ...marker.position } : null),
entity: marker.carrier,
};
},
});
clickSubscription = inputFor(viewer).onClick((event) => {
if (!enabled) return;
const target = clickTarget(event);
@@ -728,8 +702,6 @@ export function createLocalAdsbLayer({
}
function releaseInteraction() {
stockFollow?.destroy();
stockFollow = null;
clickSubscription?.();
clickSubscription = null;
}
-36
View File
@@ -1309,42 +1309,6 @@ test('a type change takes its belly offset with the new model, however soon it i
models.destroy();
});
test('a double-click follows a local aircraft with its card, until it goes, as its entity was', async (t) => {
const { bindRenderer } = await import('../../render/rendererOf.js');
const { createStubRenderer } = await import('../../render/stub/index.js');
const { followedOf } = await import('../../data/followed.js');
const renderer = createStubRenderer();
const viewer = { isDestroyed: () => false };
const unbind = bindRenderer(viewer, renderer);
const receiver = fakeReceiver({ mode: 'adsb', connected: true });
const clock = { now: 100_000 };
const { layer } = await enabledLayer(receiver, clock, null, {
viewer: { viewer, draw: renderer.draw },
});
t.after(() => {
layer.destroy();
unbind();
renderer.destroy();
});
receiver.set({ aircraft: [record()] });
await layer.update();
const set = renderer.testing.sets().find((id) => id.endsWith(':markers'));
renderer.testing.scriptPicks(() => [
{ set, id: 'local-adsb:abc123', surface: false },
]);
renderer.testing.pointer('dblclick', 10, 10);
const followed = followedOf(viewer);
assert.ok(followed, 'the aircraft is followed');
assert.equal(followed.key, 'local-adsb:abc123');
assert.ok(followed.entity, 'its entity record shows the tracked card');
assert.equal(typeof followed.displayPosition, 'function');
assert.ok(followed.labelModel?.title, 'with its card');
receiver.set({ aircraft: [] });
clock.now += 10 * 60_000;
await layer.update();
assert.equal(followedOf(viewer), null, 'gone, it is no longer followed');
});
test('a click on a UAT ring selects its aircraft, as the ring was a point on its entity', async (t) => {
const receiver = fakeReceiver({ mode: 'adsb', connected: true });
const feeds = fakeFeeds();