mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-19 01:32:19 +00:00
fix(input): no double-click follow or zoom on the map
The globe viewer's own double-click tracked a picked entity with a position or zoomed to one without. Layers moving onto the draw port had it re-created one by one (data/stockFollow.js); following is a click in GEV, so the viewer's handler is removed where the viewer is made and every re-creation goes: earthquakes, cyclones, air quality, news, perimeters, drone airspace, ghost maps, places, radio, cables, CCTV, ALPR, launches, bikeshare, Local ADS-B, installations, directions, trails, data packs, annotations, the library's view and local GeoJSON. The Cockpit's own double-click and the draw tool's finishing double-click stay.
This commit is contained in:
1 parent
bb2d22dbce
commit
b86014244d
69 files changed
+94
-2797
No files matched your search
@@ -446,33 +446,3 @@ test('a mark removed and added again draws afresh; two renderers on one viewer k
|
||||
assert.equal(route._draw, null, 'a destroyed renderer draws nothing more');
|
||||
assert.equal([...draw.sets.values()].filter((r) => !r.disposed).length, 0);
|
||||
});
|
||||
|
||||
test('a double-click follows a pin and zooms to an area, as their entities were; a removed pin ends it', async (t) => {
|
||||
const { createStubRenderer } = await import('../render/stub/index.js');
|
||||
const renderer = createStubRenderer();
|
||||
const v = { isDestroyed: () => false };
|
||||
const unbind = bindRenderer(v, renderer);
|
||||
const r = createWorldAnnotationRenderer(v);
|
||||
t.after(() => {
|
||||
r.destroy();
|
||||
unbind();
|
||||
renderer.destroy();
|
||||
});
|
||||
const [, area, pin] = marks();
|
||||
r.add(area);
|
||||
r.add(pin);
|
||||
const setOf = (anno, kind) => anno._draw[kind].id;
|
||||
let hit = null;
|
||||
renderer.testing.scriptPicks(() => (hit ? [hit] : []));
|
||||
hit = { set: setOf(pin, 'points'), id: 'marker', surface: false };
|
||||
renderer.testing.pointer('dblclick', 10, 10);
|
||||
assert.ok(renderer.camera.followed, 'the pin is followed');
|
||||
hit = { set: setOf(area, 'shapes'), id: 'fill:0', surface: false };
|
||||
renderer.testing.pointer('dblclick', 10, 10);
|
||||
assert.equal(renderer.camera.followed, null, 'the area is zoomed to');
|
||||
hit = { set: setOf(pin, 'shapes'), id: 'ring', surface: false };
|
||||
renderer.testing.pointer('dblclick', 10, 10);
|
||||
assert.ok(renderer.camera.followed, 'its ring follows it too');
|
||||
r.remove(pin);
|
||||
assert.equal(renderer.camera.followed, null, 'removed: no longer followed');
|
||||
});
|
||||
Reference in new issue
Block a user