fix(satellites): a hidden class takes the ISS ring, label and docked names

Class toggles only hid points: with Stations off the ISS's orbit ring and
its label still drew, and each catalog refresh showed the ring again. The
ring and label now follow the ISS's class, and the tracked card no longer
names a docked companion whose class is hidden.

A failed Starlink load reverted to the core catalog without applying class
visibility again, so the core catalog's own Starlink points stayed on while
the chip, legend and lists said Starlink was off, and classes.starlink kept
reading true. Both are put right on failure.
This commit is contained in:
Sameh Khamis committed 2026-11-08 15:16:01 -08:00
1 parent 8bd16b0be9
commit b59eb8b18c
5 files changed
+105 -7

No files matched your search

+24 -6
View File
@@ -48,16 +48,30 @@ export function createControls({ state: layerState, services, parts, source }) {
/**
* Show or hide every point by its class. The tracked satellite's point
* stays hidden (its entity draws the dot).
* stays hidden (its entity draws the dot). The ISS's ring and label go
* with its class.
*/
function _applyClassVisibility() {
for (const [noradId, point] of layerState._points) {
if (noradId === layerState._trackedNorad) continue;
point.show = _classVisible(noradId);
}
const issPath = layerState._orbitPaths.get(ISS_NORAD);
if (issPath) issPath.primitive.show = _issOrbitVisible();
parts.labels?._syncIssOverlay?.();
layerState._detectionObjects.clear();
}
/** Whether the ISS's ring shows: orbits on, the layer drawing, its class on. */
function _issOrbitVisible() {
return (
satelliteVisualsVisible(
layerState._enabled,
layerState._params.showOrbits,
) && _classVisible(ISS_NORAD)
);
}
/**
* The row's info line while the classes rest on old or missing SATCAT
* evidence (`_satcatState`), and an empty one otherwise.
@@ -530,11 +544,14 @@ export function createControls({ state: layerState, services, parts, source }) {
}
if (params.showOrbits !== undefined) {
layerState._params.showOrbits = params.showOrbits !== false;
for (const path of layerState._orbitPaths.values())
path.primitive.show = satelliteVisualsVisible(
layerState._enabled,
layerState._params.showOrbits,
);
for (const [noradId, path] of layerState._orbitPaths)
path.primitive.show =
noradId === ISS_NORAD
? _issOrbitVisible()
: satelliteVisualsVisible(
layerState._enabled,
layerState._params.showOrbits,
);
parts.labels._syncIssOverlay();
}
if (catalogChanged && catalog === 'dense') {
@@ -690,6 +707,7 @@ export function createControls({ state: layerState, services, parts, source }) {
_classTally,
_classVisible,
_applyClassVisibility,
_issOrbitVisible,
satelliteVisualsVisible,
satelliteCatalogModeChanged,
methods,