mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
Read the HUD and share-link camera through the renderer's camera port
The first camera-family slice. The camera port's events move into a shared module (render/camera/events.js) that the stub and the Cesium port both use: listener lists, delivery with errors reported, and the contract's per-listener `changed` measure. The Cesium port gains: - camera.on: `changed` measured per listener on every tick, where Cesium measures its single threshold (the counts match Cesium's own at each threshold); moveStart and moveEnd relayed from Cesium's camera; - camera.viewRectangle, in degrees (now in CESIUM_CHECKS); - lon and lat in pose, and NaN where Cesium has no cartographic position. Code that still holds the viewer reaches the renderer through rendererOf(viewer); the application renderer binds it on create and unbinds on destroy. The HUD reads its telemetry from the camera port and no longer imports Cesium (off the allow-list). The share link writes the hash from the pose. Its restore path stays on the viewer's camera for a later slice. Behaviour changes: - The share link listens to `changed` at its own 0.5 threshold, not at whatever global threshold layers had set, and also to moveEnd, so the hash always catches up with where the camera comes to rest. - The HUD's and share link's camera callbacks run from the port's single relay, ahead of other moveStart/moveEnd listeners, and a throw in one is reported to the renderer's error listeners instead of escaping from Cesium's render.
This commit is contained in:
1 parent
910185bfe0
commit
b5900b4178
28 files changed
+688
-243
No files matched your search
@@ -0,0 +1,63 @@
|
||||
// The share link's hash follows the camera through the camera port: on
|
||||
// `changed` at the port's own threshold, and on `moveEnd` when it settles.
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { ShareLinkManager } from './sharelink.js';
|
||||
import { fakeCameraPort } from './testSupport/fakeCameraPort.mjs';
|
||||
|
||||
function setup(t) {
|
||||
t.mock.timers.enable({ apis: ['setTimeout'] });
|
||||
const written = [];
|
||||
globalThis.window = {
|
||||
location: { href: 'https://gev.example/', hash: '' },
|
||||
};
|
||||
globalThis.history = { replaceState: (_s, _t, href) => written.push(href) };
|
||||
t.after(() => {
|
||||
delete globalThis.window;
|
||||
delete globalThis.history;
|
||||
});
|
||||
const camera = fakeCameraPort({
|
||||
pose: { lon: -97.7431, lat: 30.2672, height: 600 },
|
||||
});
|
||||
const manager = new ShareLinkManager({}, { camera: camera.port });
|
||||
const lat = () => new URL(written.at(-1)).hash.match(/lat=([^&]*)/)?.[1];
|
||||
return { camera, manager, written, lat };
|
||||
}
|
||||
|
||||
test('the hash catches up when the camera comes to rest', (t) => {
|
||||
const { camera, written, lat } = setup(t);
|
||||
camera.setPose({ lat: 30.3 });
|
||||
camera.emit('moveEnd');
|
||||
t.mock.timers.tick(500);
|
||||
assert.equal(written.length, 1);
|
||||
assert.equal(lat(), '30.3000');
|
||||
});
|
||||
|
||||
test('the hash follows a move past the default threshold, not below it', (t) => {
|
||||
const { camera, written, lat } = setup(t);
|
||||
// The first step takes the reference view.
|
||||
camera.stepChanged();
|
||||
// A tenth of the height: below the threshold, no write.
|
||||
camera.setPose({ position: { x: 60, y: 0, z: 0 } });
|
||||
camera.stepChanged();
|
||||
t.mock.timers.tick(500);
|
||||
assert.equal(written.length, 0);
|
||||
// Past half the height: written.
|
||||
camera.setPose({ lat: 30.31, position: { x: 400, y: 0, z: 0 } });
|
||||
camera.stepChanged();
|
||||
t.mock.timers.tick(500);
|
||||
assert.equal(written.length, 1);
|
||||
assert.equal(lat(), '30.3100');
|
||||
});
|
||||
|
||||
test('destroy lets go of both camera listeners', (t) => {
|
||||
const { camera, manager, written } = setup(t);
|
||||
assert.equal(camera.listenerCount('changed'), 1);
|
||||
assert.equal(camera.listenerCount('moveEnd'), 1);
|
||||
manager.destroy();
|
||||
assert.equal(camera.listenerCount('changed'), 0);
|
||||
assert.equal(camera.listenerCount('moveEnd'), 0);
|
||||
camera.emit('moveEnd');
|
||||
t.mock.timers.tick(500);
|
||||
assert.equal(written.length, 0);
|
||||
});
|
||||
Reference in new issue
Block a user