mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Cesium: a blob's object URL is revoked once the blob is collected, not by time
Revoking a URL idle for a minute broke two things: the icon atlas, keyed by URL and never freeing a slot, took a new slot each time a blob was drawn again until it had no room; and an image material, which loads on its first draw, made hidden and shown later fetched a revoked URL and never drew. A blob now keeps one URL, revoked by a FinalizationRegistry once the blob itself is collected: anything that can still draw it holds it.
This commit is contained in:
1 parent
db80c9f141
commit
b3c6f35023
4 files changed
+70
-103
No files matched your search
@@ -36,13 +36,7 @@ import { temeToPseudoFixed } from '../../geo/celestial.js';
|
||||
import { alongLength } from '../../geo/polyline.js';
|
||||
import { clusterScreenPoints } from '../../geo/screenCluster.js';
|
||||
import { provideUnboundDraw } from '../rendererOf.js';
|
||||
import {
|
||||
blobUrl,
|
||||
blobUrlFrameDrawn,
|
||||
listenerList,
|
||||
toCartesian,
|
||||
uncaught,
|
||||
} from './common.js';
|
||||
import { blobUrl, listenerList, toCartesian, uncaught } from './common.js';
|
||||
import { createGpuIcons, GPU_ICON_CAPABILITIES } from './gpuIcons.js';
|
||||
import { blendHost } from './setBlend.js';
|
||||
import { createModelSets } from './drawModels.js';
|
||||
@@ -5202,7 +5196,6 @@ export function createCesiumDraw({
|
||||
},
|
||||
/** Each frame, after it drew: clamp state, and ground swaps. */
|
||||
afterRender() {
|
||||
blobUrlFrameDrawn();
|
||||
watchClamp();
|
||||
swapReady();
|
||||
// Clamped GPU icons take the ground under their segments.
|
||||
|
||||
Reference in new issue
Block a user