mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-21 10:42:22 +00:00
feat(globe): picks on input payloads
input.on('click'|'doubleClick'|'move', fn, { pick, drill }) delivers
{ …event, picked, drilled }: PickResult { id, owner, instance, primitive
(Cesium) } names the mover set (and instance) or line hit. One pick (and
one drill, as deep as the deepest listener) per event, shared by its
listeners; moves with picks are coalesced to one delivery per frame with
the latest position (src/globe/pickDelivery.js). Option checks in the
contract (normalizeInputOptions).
- Cesium: scene.pick / drillPick, and the picker names the owner: movers
map billboards, points and models to their set and instance, lines
their primitives to the line.
- Navara: a click with pick takes Navara's GPU pick of the same gesture
(featureClick; its pick helper answers on the same pointerup, usually
before the engine's click, so a fresh answer waits for it; otherwise
the click waits up to 250 ms, then the CPU pick). Navara 0.2.1 answers
clicks in quick succession with the first click's pick: a GPU answer
whose instance is not drawn near the click is stale and the CPU pick
answers. Hover, drill and the synchronous picker.pick/drillPick are CPU
picks (src/globe/cpuPicks.js) of pickable mover sets and pickable lines
(within half the width + 3 px), behind the globe excluded, nearest
first; lines are picked on the CPU after an empty GPU answer.
picker.clickStats() (Navara only) counts the answers and latencies.
- The fake engine picks its own movers and lines on the CPU unless
scripted.
- The contract suite clicks with real pointer events (puppeteer) on both
engines: a sprite is picked with its owner and instance, the map picks
nothing, two sprites in one place drill both, a line is picked, a
hover picks the sprite under it. Navara, 20 clicks: payload p50 2.8 ms,
p95 4.1 ms after the click (puppeteer dispatch included), 20/20 GPU
answers. The Cesium harness keeps the first-run card closed.
This commit is contained in:
1 parent
86aa0bc9ba
commit
b0cb8ce881
26 files changed
+1267
-68
No files matched your search
@@ -497,3 +497,48 @@ test('fake lines keep their positions, colour, matrix and visibility', () => {
|
||||
line.destroy();
|
||||
assert.equal(engine.fake.line('trail'), undefined);
|
||||
});
|
||||
|
||||
test('input listeners asking for picks get the pick and the drill in the payload', () => {
|
||||
const engine = createFakeEngine();
|
||||
engine.fake.script('pick', (screen) =>
|
||||
screen.x === 10
|
||||
? { id: 'ae01ce', owner: 'flights', instance: 3 }
|
||||
: undefined,
|
||||
);
|
||||
engine.fake.script('drillPick', (screen, limit) =>
|
||||
[{ id: 'a' }, { id: 'b' }, { id: 'c' }].slice(0, limit),
|
||||
);
|
||||
const seen = [];
|
||||
engine.input.on('click', (event) => seen.push(['plain', event]));
|
||||
engine.input.on('click', (event) => seen.push(['pick', event]), {
|
||||
pick: true,
|
||||
drill: 2,
|
||||
});
|
||||
engine.input.on('move', (event) => seen.push(['hover', event]), {
|
||||
pick: true,
|
||||
});
|
||||
engine.fake.input('click', { position: { x: 10, y: 5 } });
|
||||
engine.fake.input('move', {
|
||||
startPosition: { x: 0, y: 0 },
|
||||
endPosition: { x: 10, y: 5 },
|
||||
});
|
||||
engine.fake.input('click', { position: { x: 99, y: 5 } });
|
||||
assert.deepEqual(seen[0], ['plain', { position: { x: 10, y: 5 } }]);
|
||||
assert.deepEqual(seen[1][1].picked, {
|
||||
id: 'ae01ce',
|
||||
owner: 'flights',
|
||||
instance: 3,
|
||||
});
|
||||
assert.deepEqual(seen[1][1].drilled, [{ id: 'a' }, { id: 'b' }]);
|
||||
assert.deepEqual(seen[2][1].picked.id, 'ae01ce');
|
||||
assert.equal(seen[2][1].drilled, undefined, 'no drill unless asked');
|
||||
assert.equal(seen[4][1].picked, undefined);
|
||||
assert.throws(
|
||||
() => engine.input.on('click', () => {}, { drill: -1 }),
|
||||
TypeError,
|
||||
);
|
||||
assert.throws(
|
||||
() => engine.input.on('down', () => {}, { pick: true }),
|
||||
TypeError,
|
||||
);
|
||||
});
|
||||
Reference in new issue
Block a user