mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
Check the globe contract by behaviour on every engine
The contract suite is split into one module per area and grows from 87 to 114 checks, each named after the member it exercises: a gesture during a flight does not cut it, a render request inside a frame draws the next one, a pure rotation raises changed, ground corridors are as wide in CSS pixels at device scale 2, imagery replans on resize, drapes draw only on their surface, sampleTerrainMostDetailed keeps order and passes on a rejection, terrainRevision changes on a new terrain and on fallback, follows raise followChanged on retarget, and a mesh, a ground fill and an imagery pixel draw the colour asked for. In the browser Cesium passes all 113 it runs at device scale 1 and 2; Navara passes 110 of 111 and reports its single-colour mesh, drawn before tone mapping, as a known failure. scripts/contract-mutants.test.mjs breaks one promise of the fake engine at a time, 30 mutants in all, and names the check that catches each; the list of contract members the suite never calls is down to five. maps.errors reports tile and terrain errors where an engine has them (the tileErrors capability: Cesium yes, Navara no), and the map controller falls back to another map only where it does; movers.list() rows tell whether a set is shown, as the other families do; FollowHandle .name and PickResult.primitive are marked deprecated. qa-contract-suite takes --dpr and the ANGLE backend from QA_ANGLE.
This commit is contained in:
1 parent
9c2a2d6951
commit
b03edaaf2b
39 files changed
+7247
-5194
No files matched your search
@@ -166,7 +166,7 @@
|
||||
* @property {any} [native]
|
||||
* @property {object} [label] FollowOptions.label.
|
||||
* @property {string} [name] Cesium only: the followed Entity's name, else its
|
||||
* id (a follow without an Entity has none).
|
||||
* id (a follow without an Entity has none). @deprecated Compatibility field.
|
||||
*
|
||||
* @typedef {'click'|'doubleClick'|'move'|'down'|'up'} InputType
|
||||
* @typedef {'ctrl'|'shift'|'alt'} InputModifier
|
||||
@@ -346,7 +346,7 @@
|
||||
* pickId); undefined for map tiles.
|
||||
* @property {string} [owner] The mover set or line the pick belongs to.
|
||||
* @property {number} [instance] The mover instance index.
|
||||
* @property {any} [primitive] Cesium only, for compatibility.
|
||||
* @property {any} [primitive] Cesium only, for compatibility. @deprecated Compatibility field.
|
||||
* @property {any} [content] 3D tile content when map tiles were picked (what
|
||||
* a surface-pick check reads), else undefined.
|
||||
* @property {any} [object] The engine's own pick result, for engine-specific code.
|
||||
@@ -368,6 +368,11 @@
|
||||
* cannot be built (the current source then stays). Base imagery and
|
||||
* photoreal tiles share one switch order: the call made last decides what
|
||||
* shows, and a superseded call settles without showing anything.
|
||||
* @property {EngineEvent} [errors] With the tileErrors capability, reports
|
||||
* provider failures as { source, kind: 'tile' | 'terrain', status }, where
|
||||
* source is the description passed to the setter and status is the HTTP
|
||||
* status code when known (undefined otherwise). Replaced sources stop
|
||||
* reporting; engines without provider error events omit this capability.
|
||||
* @property {(source: object) => Promise<void>} setBaseImagery
|
||||
* @property {(source: object) => Promise<void>} setTerrain
|
||||
* @property {(source: object | null) => Promise<void>} setPhotorealTiles
|
||||
@@ -481,7 +486,7 @@
|
||||
*
|
||||
* @typedef {object} GlobeMovers
|
||||
* @property {(options: MoverSetOptions) => MoverSet} createSet
|
||||
* @property {() => { id: string, kind: string, count: number, capacity: number }[]} list
|
||||
* @property {() => { id: string, kind: string, count: number, capacity: number, shown: boolean }[]} list
|
||||
*
|
||||
* @typedef {object} LineOptions
|
||||
* A dynamic polyline (src/globe/lines.js checks and defaults these).
|
||||
@@ -1093,6 +1098,7 @@ const isNameList = (value) =>
|
||||
// group whole or not at all (assertGlobeEngine); engineCapabilities says
|
||||
// which it has.
|
||||
const OPTIONAL_SHAPE = {
|
||||
tileErrors: { 'maps.errors': isEngineEvent },
|
||||
visualStyles: {
|
||||
'render.visualStyles': isNameList,
|
||||
'render.setStyle': isFunction,
|
||||
|
||||
Reference in new issue
Block a user