From afa9e763f211d224c014f506899707cc254f2da6 Mon Sep 17 00:00:00 2001
From: Jeff Blakely <7987380+jeffblakely@users.noreply.github.com>
Date: Tue, 13 Oct 2026 10:06:41 -0400
Subject: [PATCH] test(bikeshare): check PBSC activation from real station
 coordinates

Assert through computeInRangeCities that a camera over each system's
outermost live-feed station activates it, including both Kona and Hilo
for HIBike, and that HIBike stays off over Honolulu. Drop Pennsylvania
from the changelog: Philadelphia's Indego is already registered.
---
 CHANGELOG.md                               |  2 +-
 src/layers/bikeshare/usPbscCities.test.mjs | 66 ++++++++++++++++++----
 2 files changed, 57 insertions(+), 11 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5fd137e89..eedaf06d8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 - Add Detroit (MoGo), Pittsburgh (POGOH), Aspen (WE-cycle) and Kona & Hilo
   (HIBike) to the GBFS bikeshare registry, the layer's first stations in
-  Michigan and Pennsylvania.
+  Michigan.
 
 - Treat explicitly current, complete empty vessel coverage as a successful update,
   clearing obsolete contacts while retaining stale or incomplete snapshots.
diff --git a/src/layers/bikeshare/usPbscCities.test.mjs b/src/layers/bikeshare/usPbscCities.test.mjs
index 4ff15c370..aba2d20ec 100644
--- a/src/layers/bikeshare/usPbscCities.test.mjs
+++ b/src/layers/bikeshare/usPbscCities.test.mjs
@@ -1,19 +1,48 @@
 import assert from 'node:assert/strict';
 import test from 'node:test';
 import { CITY_BY_ID } from './registry.js';
+import { createModel } from './model.js';
+import { createViewport } from './viewport.js';
 import { isAllowedGbfsHost, isAllowedGbfsPath } from '../../data/gbfsSource.js';
-import { CITY_RANGE_BASE_KM } from './policy.js';
 
-// Each city's PBSC host, and its farthest station from the registered centre
-// as measured against the live feed (km), so a camera over any part of the
-// system activates it.
+// Each city's PBSC host, and the stations farthest from its registered centre
+// in the live feed (checked 2026-10-13). HIBike's centre sits between its two
+// towns, so it lists the outermost station in each.
 const CITIES = {
-  'detroit-mogo': { host: 'detroit.publicbikesystem.net', provider: 'MoGo', farthestKm: 22.4 },
-  'pittsburgh-pogoh': { host: 'pittsburgh.publicbikesystem.net', provider: 'POGOH', farthestKm: 9.1 },
-  'aspen-we-cycle': { host: 'aspen.publicbikesystem.net', provider: 'WE-cycle', farthestKm: 42.6 },
-  'hawaii-island-hibike': { host: 'kona.publicbikesystem.net', provider: 'HIBike', farthestKm: 53.8 },
+  'detroit-mogo': {
+    host: 'detroit.publicbikesystem.net',
+    provider: 'MoGo',
+    stations: [{ name: 'Robina Ave & W Twelve Mile Rd', lat: 42.50288, lon: -83.18921 }],
+  },
+  'pittsburgh-pogoh': {
+    host: 'pittsburgh.publicbikesystem.net',
+    provider: 'POGOH',
+    stations: [{ name: 'Wilkinsburg Park & Ride', lat: 40.446951, lon: -79.888593 }],
+  },
+  'aspen-we-cycle': {
+    host: 'aspen.publicbikesystem.net',
+    provider: 'WE-cycle',
+    stations: [{ name: 'Cowen Dr | Hwy 133', lat: 39.413115, lon: -107.220634 }],
+  },
+  'hawaii-island-hibike': {
+    host: 'kona.publicbikesystem.net',
+    provider: 'HIBike',
+    stations: [
+      { name: 'Kona Community Center', lat: 19.642932, lon: -156.004962 },
+      { name: 'Kealoha Beach Park, Hilo', lat: 19.733317, lon: -155.029202 },
+    ],
+  },
 };
 
+// The production range check, with no viewer or fetches behind it.
+const parts = { model: createModel({ state: {}, services: {}, parts: {}, source: null }) };
+const { computeInRangeCities } = createViewport({
+  state: {},
+  services: { render: { governorRequestRender() {} } },
+  parts,
+  source: null,
+});
+
 test('the added US PBSC systems are registered and readable through the proxy', () => {
   for (const [id, expected] of Object.entries(CITIES)) {
     const city = CITY_BY_ID.get(id);
@@ -25,7 +54,24 @@ test('the added US PBSC systems are registered and readable through the proxy',
       assert.ok(isAllowedGbfsHost(url.hostname), `${id} host ${url.hostname}`);
       assert.ok(isAllowedGbfsPath(url.pathname), `${id} path ${url.pathname}`);
     }
-    const radius = Math.max(CITY_RANGE_BASE_KM, city.loadRadiusKm);
-    assert.ok(radius > expected.farthestKm, `${id} radius ${radius} covers its farthest station`);
   }
 });
+
+test('a camera over each outermost station activates its system', () => {
+  for (const [id, expected] of Object.entries(CITIES)) {
+    for (const station of expected.stations) {
+      assert.ok(
+        computeInRangeCities({ lat: station.lat, lon: station.lon }).has(id),
+        `${station.name} activates ${id}`,
+      );
+    }
+  }
+});
+
+test('HIBike stays inactive away from Hawaii Island', () => {
+  // Honolulu is about 270 km from the HIBike centre.
+  assert.equal(
+    computeInRangeCities({ lat: 21.3069, lon: -157.8583 }).has('hawaii-island-hibike'),
+    false,
+  );
+});