From 7ea0903fe2b2e88def4fdf33d6146deed75374a9 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Tue, 17 Nov 2026 15:59:10 -0800 Subject: [PATCH 1/2] fix(conformance): draw.models.parts waits for frames, not a settled scene, while a part spins --- src/render/conformance/checks/ports.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/render/conformance/checks/ports.js b/src/render/conformance/checks/ports.js index 27182d1342..149fddb3a5 100644 --- a/src/render/conformance/checks/ports.js +++ b/src/render/conformance/checks/ports.js @@ -4284,13 +4284,16 @@ export function portChecks() { ok(pickedAt(armAt(forward)), 'and stays ahead'); } - await show( + // A spinning part asks for frames for as long as it spins, so the + // scene never settles; wait for frames to be drawn instead. + set.upsert([ model('m', { spin: { pod: 90 }, deploy: { pod: 1, missing: 1 }, poses: { pod: { highlight: true }, missing: { hidden: true } }, }), - ); + ]); + await drawn(h, r, 3); if (picks) ok(pickedAt(pos), 'spinning and highlighted, where it is'); await show(model('m')); if (picks) ok(pickedAt(pos), 'back at rest'); From d146c4bb5a76bd45ca1f33b29e1d8b5c42c9de05 Mon Sep 17 00:00:00 2001 From: Sameh Khamis Date: Tue, 17 Nov 2026 15:59:17 -0800 Subject: [PATCH 2/2] Add the changelog entry for the parts check fix --- changelog.d/1792-parts-check-while-spinning.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelog.d/1792-parts-check-while-spinning.md diff --git a/changelog.d/1792-parts-check-while-spinning.md b/changelog.d/1792-parts-check-while-spinning.md new file mode 100644 index 0000000000..504c0edf25 --- /dev/null +++ b/changelog.d/1792-parts-check-while-spinning.md @@ -0,0 +1,2 @@ +- Fix the model parts conformance check timing out while a part spins: it + waits for drawn frames instead of a settled scene (samehkhamis, #1792).