mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
refactor(overlays): use the globe engine
The world overlay host takes its frames (frames.postRender), camera events
(camera.moveEnd), canvas size (host.size), projection matrix
(projector.viewProjection), horizon test (projector.horizonVisible) and
render requests (render.request('world-overlay')) from the globe engine.
initWorldOverlay accepts an engine or, for callers that still hold a
viewer, resolves the viewer's engine through engineFromViewer.
Contract: camera.position(result) becomes camera.livePosition, one
engine-owned object holding the current position, so per-frame readers
and paint lanes keep a live camera position without allocating; engine
events gain raiseValue for argument-list-free frame dispatch. Steady-state
frame allocation is unchanged (worker probe, 30 chunks: 2696/9536/38593
B/frame before and after; detection 473749 -> 408085).
This commit is contained in:
1 parent
58a196374f
commit
aaa6074663
11 files changed
+284
-134
No files matched your search
@@ -2297,3 +2297,70 @@ test('promoting an ambient entry to selected paints it once with no fading dupli
|
||||
assert.equal(paint(), 1, 'deselect restores the ambient card without re-entry cooldown');
|
||||
} finally { env.cleanup(); }
|
||||
});
|
||||
|
||||
// --- The host on a globe engine (src/globe contract) -------------------------
|
||||
|
||||
async function fakeEngineHost() {
|
||||
const { createFakeEngine } = await import('../globe/testing/fakeEngine.js');
|
||||
const env = installMockEnvironment({ width: 400, height: 300, dpr: 1 });
|
||||
const engine = createFakeEngine({
|
||||
width: 400,
|
||||
height: 300,
|
||||
container: env.viewer.container,
|
||||
});
|
||||
return { env, engine };
|
||||
}
|
||||
|
||||
test('the host runs on a globe engine: frames, camera events and canvas size', async () => {
|
||||
const { env, engine } = await fakeEngineHost();
|
||||
initWorldOverlay(engine);
|
||||
initWorldOverlay(engine);
|
||||
assert.equal(engine.frames.postRender.numberOfListeners, 1);
|
||||
assert.equal(engine.camera.moveEnd.numberOfListeners, 1);
|
||||
const surface = env.document.getElementById('world-overlay-detection-surface');
|
||||
assert.equal(surface.parentElement, env.viewer.container,
|
||||
'the detection surface hangs off the engine host container');
|
||||
setOverlayEntries('engine', [selectedEntry('CENTRE', { position: Cesium.Cartesian3.fromDegrees(0, 0, 0) })]);
|
||||
engine.fake.frame();
|
||||
const canvas = env.document.getElementById('world-overlay-canvas');
|
||||
assert.equal(canvas.width, 400, 'sized from engine.host.size()');
|
||||
assert.equal(canvas.height, 300);
|
||||
assert.equal(getWorldOverlayDiagnostics().paintedCount, 1);
|
||||
destroyWorldOverlay();
|
||||
assert.equal(engine.frames.postRender.numberOfListeners, 0);
|
||||
assert.equal(engine.camera.moveEnd.numberOfListeners, 0);
|
||||
env.cleanup();
|
||||
});
|
||||
|
||||
test('on a globe engine the host projects with viewProjection and culls with horizonVisible', async () => {
|
||||
const { env, engine } = await fakeEngineHost();
|
||||
initWorldOverlay(engine);
|
||||
setOverlayEntries('engine', [
|
||||
selectedEntry('NEAR', { position: Cesium.Cartesian3.fromDegrees(0, 0, 0), horizonCull: true }),
|
||||
selectedEntry('FAR', { position: Cesium.Cartesian3.fromDegrees(0, 0, 0), horizonCull: true,
|
||||
cullPosition: Cesium.Cartesian3.fromDegrees(180, 0, 0) }),
|
||||
]);
|
||||
engine.fake.frame();
|
||||
assert.equal(getOverlayPaintRect('engine', 'NEAR') !== null, true);
|
||||
assert.equal(getOverlayPaintRect('engine', 'FAR'), null, 'hidden behind the globe');
|
||||
const rect = getOverlayPaintRect('engine', 'NEAR');
|
||||
const centre = engine.projector.worldToWindow(Cesium.Cartesian3.fromDegrees(0, 0, 0));
|
||||
assert.ok(Math.abs(rect.anchorX - centre.x) < 1e-6 && Math.abs(rect.anchorY - centre.y) < 1e-6,
|
||||
'anchored at the projected point');
|
||||
env.cleanup();
|
||||
});
|
||||
|
||||
test('on a globe engine the host hands painters the live camera position and requests renders by reason', async () => {
|
||||
const { env, engine } = await fakeEngineHost();
|
||||
initWorldOverlay(engine);
|
||||
let frame = null;
|
||||
registerWorldOverlayPaintLane('detection', (value) => { frame = value; },
|
||||
{ id: 'detection', active: true, target: 'detection' });
|
||||
setOverlayEntries('engine', [selectedEntry('CENTRE', { position: Cesium.Cartesian3.fromDegrees(0, 0, 0) })]);
|
||||
assert.ok(engine.fake.callsOf('render.request').some(({ args }) => args[0] === 'world-overlay'));
|
||||
engine.fake.frame();
|
||||
assert.equal(frame.cameraPosition, engine.camera.livePosition);
|
||||
assert.equal(frame.occluder.isPointVisible(Cesium.Cartesian3.fromDegrees(180, 0, 0)), false);
|
||||
assert.equal(frame.occluder.isPointVisible(Cesium.Cartesian3.fromDegrees(0, 0, 0)), true);
|
||||
env.cleanup();
|
||||
});
|
||||
Reference in new issue
Block a user