mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-18 09:12:18 +00:00
Stories: name the Opened in GEV toast for what it is
This commit is contained in:
1 parent
a5065743d9
commit
a9990018ea
9 files changed
+30
-29
No files matched your search
@@ -171,7 +171,7 @@ test('a failed load is reported and the next open tries again', async () => {
|
||||
|
||||
test('a Stories link that cannot load is reported too', async () => {
|
||||
setActivePinia(createPinia());
|
||||
history.replaceState(null, '', '/?story=worldfx%3Afire-tracker');
|
||||
history.replaceState(null, '', '/?story=other%3Afire-tracker');
|
||||
const store = useStoriesStore();
|
||||
let failures = 0;
|
||||
bootStories({
|
||||
|
||||
@@ -918,7 +918,7 @@ export function createStoriesController({
|
||||
director.styleManager?.setPanelCollapsed?.('scene-panel', false, {
|
||||
explicit: true,
|
||||
});
|
||||
store.hostedToast = {
|
||||
store.openedToast = {
|
||||
id: story.id,
|
||||
title: story.title,
|
||||
atMs,
|
||||
|
||||
@@ -258,7 +258,7 @@ test('reopening while a scene tears down keeps the view from before Stories', as
|
||||
controller.open();
|
||||
controller.openStory('gev:bhote-koshi-nepal-scene');
|
||||
director.running = true;
|
||||
const toast = store.hostedToast;
|
||||
const toast = store.openedToast;
|
||||
const closing = controller.openInGev();
|
||||
// The scene has moved the camera; the person opens Stories again at once.
|
||||
camera.position = { x: 9, y: 9, z: 9 };
|
||||
@@ -267,7 +267,7 @@ test('reopening while a scene tears down keeps the view from before Stories', as
|
||||
await closing;
|
||||
assert.deepEqual(director.selected, []);
|
||||
assert.deepEqual(director.styleManager.panels, []);
|
||||
assert.equal(store.hostedToast, toast);
|
||||
assert.equal(store.openedToast, toast);
|
||||
assert.equal(camera.views.length, 0, 'no restore under the reopened Stories');
|
||||
await controller.close();
|
||||
const { x, y, z } = camera.views.at(-1).destination;
|
||||
|
||||
@@ -32,8 +32,8 @@ export function creditPlacement({ map, feed, width, height }) {
|
||||
|
||||
/**
|
||||
* Where the Stories button sits: just left of the leftmost visible control
|
||||
* in GEV's top-right corner — the ACTIVE STYLE readout in GEV, the account
|
||||
* avatar (with or beside the readout) in GEV Hosted — top-aligned with it.
|
||||
* in GEV's top-right corner — the ACTIVE STYLE readout, or an element placed
|
||||
* in that corner (with or beside the readout) — top-aligned with it.
|
||||
* Where none of those shows (GEV's phone layout, whose top row of icon
|
||||
* buttons spans the corner), it goes icon-only just under the right-hand
|
||||
* column of corner actions, aligned with its right edge.
|
||||
|
||||
Reference in new issue
Block a user