mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-21 02:32:18 +00:00
Let the camera picker pick the opening CCTV camera
The picker preselected the active camera, and a native select fires no
change for the option it already shows. So while CCTV was still following
the view, choosing the camera the picker showed did nothing, and the next
pan switched to another camera.
The layer now reports whether the active camera is the opening one
(activeCameraProvisional). While it is, the picker shows that camera from
a hidden, disabled first option, so choosing it from the list is a change
and ends automatic selection; closing the list keeps it. A same-camera
pick that ends the opening pick notifies listeners so the picker drops the
hidden option, and reopenNearestCamera passes { opening: true } so its own
notification already carries the opening state.
docs/CURRENT-STATE.md now says when automatic selection ends. Tests cover
the hidden option, confirming and dismissing the picker before a pan, the
notification, and focusNearestToPoint, which is now on main.
This commit is contained in:
1 parent
fe37cacba0
commit
a6eecee157
12 files changed
+315
-30
No files matched your search
@@ -2000,6 +2000,18 @@ The view pass reruns while the camera moves, paced by its own cost. The camera
|
||||
picker lists the cameras in view, active camera first, and closes with the
|
||||
count of cameras outside the view.
|
||||
|
||||
Turning CCTV on opens on the camera nearest the view. Until someone picks a
|
||||
camera, each settled move, such as a shared view's flight landing, moves it to
|
||||
the camera then nearest the view. Automatic selection ends at the first pick:
|
||||
NEAREST, PREV or NEXT, a camera chosen in the picker, a click on a camera, a
|
||||
click on empty ground that deselects, an auto-hop step, or a call to
|
||||
`selectCamera`, `focusNearest`, `focusNearestToPoint` or
|
||||
`setParams({ selectedCameraId })`, which voice and scenes use. Picking the
|
||||
camera that is already active counts. While the camera is the automatic one,
|
||||
the picker shows it from a hidden first option, so choosing that camera from
|
||||
the list is a change and ends automatic selection; closing the list without a
|
||||
choice keeps it.
|
||||
|
||||
Traffic owns its rendered-surface observer only while enabled, removes it on disable/destroy, and rebuilds no cached heights on frames where the surface identity is unchanged. Its dots and heat-lines are two renderer draw sets, it animates on the frame port's preRender, and it follows the camera through the camera port at its own 5% threshold rather than the shared `percentageChanged` ledger. The surface identity is the globe port's `surfaceVersion()` and tile readiness its `isSettled('surface')`, so the layer no longer reaches Cesium. Heat-lines are always asked for draped: where the Cesium renderer cannot drape (no depth textures) its draw port draws them (and every other draped line) over the surface, in their colour where the surface hides them and hidden past the horizon, recolouring a line in place when only its colour changes, rather than the layer dropping them.
|
||||
|
||||
Traffic and bikeshare expose factories through `./layers/traffic` and
|
||||
|
||||
Reference in new issue
Block a user