mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 08:12:24 +00:00
Read the navigation and point-and-ask camera through the renderer's ports
The navigation controller and the location navigation cancel flights and read the camera's place through the camera port. Point-and-ask's camera pose key and its "around here" radius read the camera port's pose; its entity pick moves into the input dispatcher (pickAt), which picks as a click does, so the follow's helper still reads as its target. navigationController, locationNavigation and pointerPick leave the Cesium allow-list. Their package entries (./ui/navigation and three voice entries) no longer load the Cesium adapter: given a viewer of a caller's own, they find its camera once the caller loads ./render/cesium/unbound. They are listed as such in the unbound camera test, which fails if one starts loading the factory again.
This commit is contained in:
1 parent
3484bfa56d
commit
a2c4d27b5a
9 files changed
+92
-35
No files matched your search
@@ -119,9 +119,6 @@
|
||||
"src/ui/cockpitController.js",
|
||||
"src/ui/flyToDataSource.js",
|
||||
"src/ui/imageryBoxTool.js",
|
||||
"src/ui/locationNavigation.js",
|
||||
"src/ui/navigationController.js",
|
||||
"src/ui/shareFollow.js",
|
||||
"src/voice/gevActions.js",
|
||||
"src/voice/pointerPick.js"
|
||||
"src/voice/gevActions.js"
|
||||
]
|
||||
@@ -86,6 +86,19 @@ const DRAW_FROM_CALLER = new Set([
|
||||
'./layers/air-quality',
|
||||
]);
|
||||
|
||||
/**
|
||||
* Cesium-free entries that reach the camera port but draw nothing: given a
|
||||
* viewer with no renderer bound, they find no camera
|
||||
* (`findCamera` is null) and leave it alone until the caller loads
|
||||
* `./render/cesium/unbound`.
|
||||
*/
|
||||
const CAMERA_FROM_CALLER = new Set([
|
||||
'./ui/navigation',
|
||||
'./voice/commands',
|
||||
'./voice/controller',
|
||||
'./voice/realtime-session',
|
||||
]);
|
||||
|
||||
const pkg = JSON.parse(readFileSync(path.join(root, 'package.json'), 'utf8'));
|
||||
|
||||
/** The browser module an export resolves to, or null for Node-only ones. */
|
||||
@@ -196,6 +209,10 @@ test('every public entry that reaches the renderer bridge loads the unbound came
|
||||
const carrier = INJECTED[key];
|
||||
const loads = (file) => reachable(file, { eager: true }).has(FACTORY);
|
||||
if (DRAW_FROM_CALLER.has(key)) continue;
|
||||
if (CAMERA_FROM_CALLER.has(key)) {
|
||||
assert.ok(!loads(entry), `${key} loads the factory: unlist it`);
|
||||
continue;
|
||||
}
|
||||
if (!loads(entry) && !(carrier && loads(carrier))) missing.push(key);
|
||||
}
|
||||
assert.ok(bridged > 0, 'no entry reaches the bridge: the walk is broken');
|
||||
@@ -231,7 +248,11 @@ function checkLookupFactory(
|
||||
const entry = path.normalize(target.slice(2));
|
||||
if (![...reachable(entry)].some(calls)) continue;
|
||||
reaching += 1;
|
||||
if (fromCaller && DRAW_FROM_CALLER.has(key)) continue;
|
||||
if (
|
||||
fromCaller &&
|
||||
(DRAW_FROM_CALLER.has(key) || CAMERA_FROM_CALLER.has(key))
|
||||
)
|
||||
continue;
|
||||
const carrier = INJECTED[key];
|
||||
const loads = (file) => reachable(file, { eager: true }).has(factory);
|
||||
if (!loads(entry) && !(carrier && loads(carrier))) missing.push(key);
|
||||
|
||||
Reference in new issue
Block a user