mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
fix(ui): the "kept in the link" notice is readable on Navara
On Navara the engine's persistent notice came up right after the share restore's NOT ON THIS ENGINE notice and replaced it at once, so the names of the linked layers this engine lacks were never seen (and a later finite notice would in turn have wiped the engine notice for good). - ShellFeedback keeps a persistent notice that a finite one covers and brings it back when the finite one ends; a persistent notice that arrives under a live finite one waits for it. - Notices take a dwellMs; "Kept in the link: …" stays 15 s. - scripts/qa-engine-notice.mjs (headless): a Cesium share link with a layer Navara lacks, opened with ?engine=navara: notice shown with the layer name, still up 14 s later, then the engine notice is back. 4/4 (before the fix the notice never appeared). T8-T9 review item 2.
This commit is contained in:
1 parent
c493a8303b
commit
9f1a0611fa
5 files changed
+103
-5
No files matched your search
@@ -1,6 +1,9 @@
|
||||
import { LayerStateCoordinator } from '../data/layerStateCoordinator.js';
|
||||
import { APPLICATION_LAYER_DIRECTORY } from '../app/layers/directory.js';
|
||||
|
||||
/** How long the "kept in the link" notice stays up (ms). */
|
||||
export const NOT_ON_THIS_ENGINE_DWELL_MS = 15_000;
|
||||
|
||||
/** Names of the layers a link turned on that this engine does not have. */
|
||||
export function layersNotOnThisEngine(results) {
|
||||
return results
|
||||
@@ -189,6 +192,9 @@ export class ShareRestoration {
|
||||
this.showStatus('NOT ON THIS ENGINE', {
|
||||
state: 'retry',
|
||||
detail: `Kept in the link: ${names.join(', ')}`,
|
||||
// Long enough to read a list of layer names; the engine's own
|
||||
// persistent notice comes back afterwards (ShellFeedback).
|
||||
dwellMs: NOT_ON_THIS_ENGINE_DWELL_MS,
|
||||
});
|
||||
}
|
||||
cancelSelection() {
|
||||
|
||||
Reference in new issue
Block a user