mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-14 15:22:21 +00:00
Show no notice for a lost context on a page that must not reload, and log each render error once
An inline panel that lost its WebGL context showed the panel runtime's own notice and, over it, an alert dialog with no buttons that it could not act on. With allowReload false a lost context now clears the notice and shows none, as the docs already said. keepPanelRendering no longer logs render errors itself: the render failure notice logs each one. Name the Cesium private fields finishRaise and reportThrown rely on, and the version they were checked against.
This commit is contained in:
1 parent
73bd952736
commit
9d01f8df77
5 files changed
+40
-58
No files matched your search
@@ -2482,10 +2482,12 @@ Pitfalls:
|
||||
its buttons are 44 px tall on touch screens.
|
||||
|
||||
An inline conversation panel never reloads or navigates its host's page: it
|
||||
offers Retry after a render error only, and nothing after a lost context, where
|
||||
the panel runtime's own notice applies. Its timer (`keepPanelRendering()`)
|
||||
draws only while the render loop is on. An error a timer frame throws is caught
|
||||
there: it has already been raised as a render error.
|
||||
offers Retry after a render error only, and no notice after a lost context,
|
||||
where the panel runtime's own notice applies (`src/app/globePanelRuntime.js`).
|
||||
Its timer (`keepPanelRendering()`) draws only while the render loop is on and
|
||||
logs nothing itself, so each render error is logged once, by the notice. An
|
||||
error a timer frame throws is caught there: it has already been raised as a
|
||||
render error.
|
||||
|
||||
## Map Source control ownership
|
||||
|
||||
|
||||
Reference in new issue
Block a user