mirror of
https://github.com/bilawalsidhu/gods-eye-view.git
synced 2026-11-16 16:22:20 +00:00
Bring comments in line with the single application and the Navara capabilities
This commit is contained in:
1 parent
8d7f055572
commit
9cc108835e
11 files changed
+21
-22
No files matched your search
+2
-2
@@ -70,8 +70,8 @@ export function catalogControlServices(catalog) {
|
||||
}
|
||||
|
||||
/**
|
||||
* Layer roles for controls on a page without data layers (the experimental
|
||||
* Navara engine): one empty object per role, so the shell's optional calls
|
||||
* Layer roles for controls on a page without data layers: one empty object
|
||||
* per role, so the shell's optional calls
|
||||
* (`layer.method?.()`) do nothing.
|
||||
*/
|
||||
export function absentLayerControlServices() {
|
||||
|
||||
@@ -408,10 +408,10 @@ export async function createNavaraScene({
|
||||
|
||||
/**
|
||||
* The tools without a viewer (the experimental Navara engine), attached to
|
||||
* one Navara scene: the render governor on the engine, hidden-tab handling,
|
||||
* the imagery box, the engine notice and voice on the engine. The shell
|
||||
* shows which features are unavailable. Returns its annotations (none) and
|
||||
* voice.
|
||||
* one Navara scene: the render governor, hidden-tab handling, imagery box,
|
||||
* engine notice, annotations, Draw, Import, scope mask and voice. The shared
|
||||
* tools keep their session state across engines. Returns the annotation
|
||||
* board (null without a Navara view) and voice commands.
|
||||
*/
|
||||
export function attachViewerlessTools(
|
||||
{ engine, mapStackController = null },
|
||||
@@ -497,8 +497,8 @@ export function attachViewerlessTools(
|
||||
attachNavaraDraw(tools, { ...context, annotations }, { signal, defer });
|
||||
attachNavaraGeoImport(tools, context, { signal, defer });
|
||||
attachNavaraScopeMask(tools, context, { signal, defer });
|
||||
// Voice on the engine (phase 3, Task 9): the W1 tools drive the engine;
|
||||
// the Director uses the shared session; viewer-only tools declare availability.
|
||||
// Voice uses the engine and shared session services; each action checks
|
||||
// the capabilities it needs on the attached scene.
|
||||
const voiceCommands = attachSessionVoice({
|
||||
layerSession,
|
||||
voice,
|
||||
|
||||
+3
-4
@@ -29,10 +29,9 @@ import {
|
||||
* handle belong to the application; the tools bound to one globe (render
|
||||
* governor, release trim, scope mask, imagery box, tracking and visibility
|
||||
* listeners, embedded views, the debug handle's globe fields) attach to each
|
||||
* engine the page shows (src/app/sceneParts.js). Without a viewer (the
|
||||
* experimental Navara engine) the viewer-bound tools are not attached and
|
||||
* their handles are null; voice runs on the engine there
|
||||
* (src/app/navaraMode.js).
|
||||
* engine the page shows (src/app/sceneParts.js). Navara attaches the shared
|
||||
* annotation board, Draw, Import, scope mask and voice through its engine
|
||||
* adapters (src/app/navaraMode.js); the Director follows the attached engine.
|
||||
*/
|
||||
export async function createApplicationTools({
|
||||
scene,
|
||||
|
||||
@@ -110,7 +110,7 @@ test('without a viewer the tools run the governor on the engine, show the notice
|
||||
assert.equal(tools.annotations, null);
|
||||
assert.ok(tools.voiceCommands, 'voice runs on the engine');
|
||||
assert.equal(window.__gevVoiceCommands, tools.voiceCommands);
|
||||
// The W1 tools drive the engine; the viewer-only ones refuse.
|
||||
// View queries use the engine, and scene commands use the shared Director.
|
||||
const view = await voice.runner('get_current_view_state');
|
||||
assert.equal(view.ok, true);
|
||||
const scene = await voice.runner('control_scene', {
|
||||
|
||||
Reference in new issue
Block a user