fix(cctv): turning the layer on no longer flashes every camera before the view pass

The icon set was created shown, and the pass that hides cameras beyond the
horizon and thins crowded areas runs only from enable(), after init has
waited on the health check. Every frame drawn in that wait showed the whole
catalogue. The set now starts hidden; enable() culls, then shows it.
This commit is contained in:
Sameh Khamis committed 2026-11-14 13:21:59 -08:00
1 parent b277b55547
commit 9b8f45e62b
2 files changed
+8

No files matched your search

+5
View File
@@ -128,6 +128,11 @@ export function createRendering({
const set = drawOf(viewer).icons({ const set = drawOf(viewer).icons({
id: `cctv:${++iconSets}:icons`, id: `cctv:${++iconSets}:icons`,
horizonCull: true, horizonCull: true,
// Hidden until enable() has thinned and culled them
// (refreshHorizonCulling, then refreshCoverageStyles shows the set):
// shown from the start, every camera in the catalogue drew while the
// layer waited on its health check.
show: false,
drawOrder: services.sprites?.spriteDrawOrder?.('cctv') ?? 0, drawOrder: services.sprites?.spriteDrawOrder?.('cctv') ?? 0,
}); });
// Columns of no rows put the set's host in the scene now, rather than // Columns of no rows put the set's host in the scene now, rather than
+3
View File
@@ -106,6 +106,9 @@ test('focus de-emphasis fades each icon from its own color', () => {
}); });
assert.equal(drawn.focus, FOCUS_FACTOR); assert.equal(drawn.focus, FOCUS_FACTOR);
assert.equal(draw.set(setId).spec.horizonCull, true); assert.equal(draw.set(setId).spec.horizonCull, true);
// Hidden until enable() has culled and thinned the cameras: the layer
// waits on its health check between drawing them and that pass.
assert.equal(draw.set(setId).show, false);
} finally { } finally {
unbind(); unbind();
} }